Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding css deps #1

Closed
wants to merge 2 commits into from
Closed

adding css deps #1

wants to merge 2 commits into from

Conversation

mansona
Copy link

@mansona mansona commented May 4, 2014

So, as part of the way that I wanted to separate this out I created a new bower.json file in the styles folder. Obviously this doesn't matter, all it will affect is the tree paths. I don't know what the full merits of doing/not doing it this way would be.

As for the actual cssTree: it needs to be pushed into the first parameter of broccoli-sass, see "inputTrees" here: https://github.com/joliss/broccoli-sass

I don't know how this differs with less (i barely even know sass at this stage).

Also I wasn't able to get this working locally, I kept getting bad reference errors.

@mansona
Copy link
Author

mansona commented May 4, 2014

I just updated the PR to include a scss file that tests the dependancies

@rwjblue
Copy link
Owner

rwjblue commented May 4, 2014

PERFECT!!!! Thank you for showing me the basic gist of what is needed. I am testing this in c5a7031, and all works properly.

@rwjblue rwjblue closed this May 4, 2014
@mansona
Copy link
Author

mansona commented May 5, 2014

I just took a look at your test commit and i'm not 100% sure it deals with my use case. The interesting requirement in my case is that the animate dependancy actually depends directly on the compass-mixins dependancy. And if they are not included in the right way it won't work.

here in your css it includes the full vendor/foundation path: c5a7031#diff-2de80de59c74fd0a521d4a0dc3531cddR1 but in my case you don't have the ability to change the required import because compass is imported from within the animate scss: https://github.com/Blooie/compass-animate/blob/master/stylesheets/animate/_bounce.scss#L4

I know that your PR has been merged ember-cli/ember-cli#562 so i'll wait for the next release to see if it deals with this particular use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants