Update Ember CLI blueprints to 3.26.0 #198
Conversation
|
|
||
| module.exports = async function () { | ||
| return { | ||
| useYarn: true, | ||
| scenarios: [ | ||
| { | ||
| name: 'ember-lts-2.18', |
There was a problem hiding this comment.
The new scenarios for Ember 3.16, 3.20 and Embroider should be added without replacing the existing scenarios. We need them to ensure that we do not break compatibility commitment without noticing. Maybe we should add a Ember 3.12 scenario as well to cover all LTS versions since 2.18.
There was a problem hiding this comment.
I fear I got confused. The addon does not seem to run Ember Try at all. It uses a custom setup to test against multiple Ember CLI versions: https://github.com/rwjblue/ember-cli-content-security-policy/blob/master/.github/workflows/ci.yml#L145
This implicitly covers ember-source versions as well. But does not include ember-source@2.18.
It also means that Embroider tests are not run yet. Even after merging this one.
I guess we need to revisit the compatibility guarantee and test suite. But it could be done independently from this merge request.
I'm sorry that I asked you to put time into updating the ember try configuration.
jelhan
changed the title
jelhan
changed the title
Co-authored-by: Jeldrik Hanschke <jelhan@users.noreply.github.com>
Bumps [chalk](https://github.com/chalk/chalk) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/chalk/releases) - [Commits](chalk/chalk@v4.1.0...v4.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [semver](https://github.com/npm/node-semver) from 7.3.4 to 7.3.5. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/master/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.4...v7.3.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ember-cli-htmlbars](https://github.com/ember-cli/ember-cli-htmlbars) from 5.3.1 to 5.7.1. - [Release notes](https://github.com/ember-cli/ember-cli-htmlbars/releases) - [Changelog](https://github.com/ember-cli/ember-cli-htmlbars/blob/master/CHANGELOG.md) - [Commits](ember-cli/ember-cli-htmlbars@v5.3.1...v5.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…er-cli-content-security-policy into snewcomer-sn/bump-cli-latest
|
Test case that a warning is shown if QUnit version is outdated is failing for Ember CLI ~3.4. I have seen it failing for other Ember CLI versions as soon as other dependencies were touched. I think we should focus maintenance time on something more meaningful than a warning only applicable for a very old version of a dependency a consumer may use. I propose to remove that test in #248. |
No description provided.