Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minimum Python version explicit #43

Closed
albertz opened this issue Oct 27, 2021 · 0 comments
Closed

Make minimum Python version explicit #43

albertz opened this issue Oct 27, 2021 · 0 comments
Milestone

Comments

@albertz
Copy link
Member

albertz commented Oct 27, 2021

We need some check assert sys.version_info[:2] >= (3, 7) or so.
Also with some documentation of what actually we use.

  • We rely on deterministic insertion order of dict, which requires Python >=3.6 (see here).

  • We use from __future__ import annotations which requires Python >=3.7 (doc).

  • typing.Protocol requires Python >=3.8.

  • Slash (/) in function argument list to mark positional-only arguments (doc) requires Python >=3.8.

Originally posted by @albertz in #36 (comment)

Related discussion on RETURNN side: rwth-i6/returnn#487 (which currently still supports much older Python versions, also Python 2).

@albertz albertz added this to the first-release milestone Oct 27, 2021
albertz added a commit that referenced this issue Oct 27, 2021
Related:
#42 (OrderedSet or IndexedSet)
#43 (min Python version)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant