Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow launchy = false to prevent letter opener from opening emails #172

Closed
wants to merge 1 commit into from

Conversation

bradrees
Copy link

Pull Request

Issue

#117

Description

Provide the option to disable the opening of generated emails.

This change is useful during DB seed to prevent hundreds of emails being opened when you have a reasonably sized application with comprehensive seeds that cover common use cases.

This was originally authored by AmpleOrganics, and we have found it very useful, so are creating a PR to merge into main, as there is an outstanding issue that was not resolved.
AmpleOrganics@e5eddd9

PR Type

What kind of change does this PR introduce?

  • Feature

How Has This Been Tested?

  • Manual

@nashby
Copy link
Collaborator

nashby commented Jan 18, 2020

Hey @bradrees! Thank you for PR but I think proposed options in #117 are good enough to make it work for seeds.

@nashby nashby closed this Jan 18, 2020
@bradrees
Copy link
Author

I'm not sure I agree - creating a new environment is quite a big change, and breaks things like Rails.env.development?, which I know is an anti-pattern, but it still useful in a dev environment. It also doesn't allow us to disable and re-enable within the same process.

I do feel that having the basic option of a simple on/off switch is beneficial in a number of ways, and I'm clearly not the only one, as there are already outstanding issues and forks from others.

It's not like the PR is complex either, it's a boolean accessor and an if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants