-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to embedded-hal 1.0.0 #34
Conversation
hmm looks like not sure why we're seeing this here but not in embedded-hal which has an MSRV of 1.60 though. |
I was getting that MSRV error when building before d706ecd. It seems to be fixed now! Have you checked if these tests are still failing? This crate would be super handy for me. :D edit: Ah, my apologies. Using (unrelated, but I really love |
Also, another crate hit this problem and ended up implementing their own |
We might also raise the MSRV to 1.73.0 (~ 6 months old) which is when |
good call, let's do that and get something out / worry about prior versions if it turns out to be a problem ^_^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Is there anything missing or can we go ahead with a release? |
updates #32
.reverse_cell()
forRefCell
wrappingInputPin
impl without causing problems, seemed simpler to always do this than to have two possible paths)cc. @Dirbaio @MabezDev