behavior change suggestion/rfc: statusbar should report Math.floor instead of Math.round

[guppy0130]

Is your feature request related to a problem? Please describe.

I open a file with 200 LoC, 1 line uncovered. I expect the summary to not say "100% Coverage," since there's a line missing.

It currently does say 100% though, because $\frac{199}{200} * 100=99.5$, and that rounds to $100$.

Describe the solution you'd like

If there's interest/folks are okay with it, I think this line:

vscode-coverage-gutters/src/coverage-system/coverageservice.ts

Line 178 in 7b40ddc

return this.statusBar.setCoverage(Math.round((covered / total) * 100 ));

should be changed from Math.round to Math.floor. I'll file a PR for this later today, but wanted to raise the issue too for visibility

Describe alternatives you've considered

• not changing it - but this leads to the current slightly misleading output

Additional context

N/A

[ryanluker]

@guppy0130 Thanks for the ticket and the PR!
Logic + math looks good to me, I will take at a look at the PR today.