-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced webview with Live Preview extension #363
Conversation
- removed webview, it wasn't working for css + replaced with Live Preview
Pulled out webview implementation, Replaced with Microsoft's Live Preview. Updated README.md with notice of dependency on Live Preview extension.
- removed webview, it wasn't working for css + replaced with Live Preview fix(htlmview): replaced webview with Live Preview Pulled out webview implementation, Replaced with Microsoft's Live Preview. Updated README.md with notice of dependency on Live Preview extension.
…ters into use-live-view
@vxdguy Thanks for submitting a PR, I have approved the tests to run in the CI system, so you will be able to push to this branch and hopefully see them run! The approach you took looks good to me from a high level and will definitely fix those issues you referred to in the PR body. In terms of next steps, you will want to take a look at a few things (I can also assist a bit later in the weekend as well).
Let me know if you have any other questions about the extension or the repo, but otherwise I am looking forward to helping you get this PR into the mainline and out to the users 😁. |
vscode depencies updated to 1.66.0 coverage-gutters.coverageFilename includes "coverage.cobertura.xml" for dotnet support cleaned up tslint complaints within gutters.ts
@ryanluker, the PR doesn't pass the builds. The MacOS and Windows builds looks like they were cancelled. The Ubuntu build is failing tests; I'm not the best person to write javascript test due to zero experience with javascript testing and a week's worth of javascript/typescript experience. |
@vxdguy I took a bit of a look last weekend but forgot to post here that I almost had something working for the tests. I will tinker a bit more today and see where I get to around getting those cleaned up. |
@vxdguy Should be all fixed now with these 3 commits, after you take a look I can approve, and we will get this merged in! One question around the live preview though. |
@mattseddon Do you by chance know how to programmatically interact with the live preview editor, https://github.com/microsoft/vscode-livepreview? |
👋🏻 . Webviews are a PITA to test and that's if you have access to the
Hope this helps. LMK if you need any clarification or further details. 👍🏻 |
Yeah I assumed it was PITA when I could find no way to interact with it programmically via the vscode.window or the getExtension helper 😢. Thanks as always @mattseddon 👋🏻! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution @vxdguy!
Previewing the coverage summary was lacking the CSS image files due to issues with webview security sandbox settings. Removed all the webview code and used the Microsoft Live Preview extension to render the coverage summary file. Code became much simpler, but introduced dependency on a 3rd party extension.
This PR should fix #250, #298, and many other closed PR's with CSS/image/javascript issues.
PR is loosely based on:
Apologies for not meeting all the contribution requirements. This is my very first PR.
I've no idea how to run tests with node, nor how to use containers. I've been learning JS/TS for about a week; it was just enough to make this work.
TODO: package.json probably needs to be updated to show a dependency on the ms-vscode.live-server extension.
Anyway, the attached animated shows me press ctrl-shift-7 to enable gutter colorization, followed by ctrl-shift-6 to preview the coverage summary in a Live Preview window.