Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust dev container and cobertura package install path #384

Merged
merged 4 commits into from
Nov 20, 2022

Conversation

ryanluker
Copy link
Owner

@ryanluker ryanluker commented Nov 6, 2022

closes #383
@trenttobler
Background #383 (comment)

@ryanluker ryanluker linked an issue Nov 6, 2022 that may be closed by this pull request
@ryanluker ryanluker changed the title #383: Adjust dev container and cobertura Adjust dev container and cobertura package install path Nov 6, 2022
Copy link

@trenttobler trenttobler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Tested locally, and no longer seeing the error during npm installation when running from the devcontainer. Thanks!

@ryanluker ryanluker merged commit 2536f92 into master Nov 20, 2022
@ryanluker ryanluker deleted the 383-broken-devcontainer-experience-npm-ci-fails branch November 20, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken devcontainer experience: npm ci fails
2 participants