Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add toggle command #385

Merged
merged 6 commits into from
Nov 26, 2022
Merged

feat: Add toggle command #385

merged 6 commits into from
Nov 26, 2022

Conversation

anishkny
Copy link
Contributor

@anishkny anishkny commented Nov 14, 2022 •
edited
Loading

Issue:

Changes:

  • Add new boolean to track current display state.
  • Add command to show/hide coverage gutter based on boolean.
  • Tests and code linting are passing via continuous integration checks.

@anishkny anishkny mentioned this pull request Nov 14, 2022
Closed
@anishkny anishkny marked this pull request as ready for review November 14, 2022 15:36
@anishkny
Copy link
Contributor Author

Hmm not sure why this is failing. Seems to pass on my fork: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3462820220/jobs/5782213247

@ryanluker
Copy link
Owner

ryanluker commented Nov 17, 2022 •
edited
Loading

Hmm not sure why this is failing. Seems to pass on my fork: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3462820220/jobs/5782213247

Thanks for the PR @anishkny !
I think a recently visual studio code insiders change has broken the integration tests I have 🤔.
This started occuring here in the nightly scheduled builds that we do.
https://github.com/ryanluker/vscode-coverage-gutters/actions/runs/3484203088/jobs/5847104491

I will have to investigate when I get some free time next...

@anishkny
Copy link
Contributor Author

Thanks for the PR @anishkny ! I think a recently visual studio code insiders change has broken the integration tests I have 🤔. This started occuring here in the nightly scheduled builds that we do. https://github.com/ryanluker/vscode-coverage-gutters/actions/runs/3484203088/jobs/5847104491

I will have to investigate when I get some free time next...

Ok thanks. The error doesn't seem related. I will leave it with you. LMK in case of any feedback.

@ryanluker
Copy link
Owner

@anishkny There was an issue with the insiders vscode testing suite.
I have fixed up the latest master to get around this issue, please update your branch when you can, and I can give it a final review (looking good though!)

@anishkny
Copy link
Contributor Author

@ryanluker Done. Synced my fork and re-ran CI. Seems to pass: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3509504510

ryanluker
ryanluker approved these changes Nov 21, 2022
View reviewed changes
Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the contribution!

@anishkny
Copy link
Contributor Author

@ryanluker Gentle ping to get this merged. I do not have write access.

@ryanluker
Copy link
Owner

@ryanluker Gentle ping to get this merged. I do not have write access.

Whoops forgot to hit the green go button hah...

@ryanluker ryanluker merged commit 1b7414f into ryanluker:master Nov 26, 2022
@ryanluker ryanluker added this to the 2.11.0 milestone Nov 26, 2022
@ryanluker ryanluker modified the milestones: 2.11.0, 2.10.3 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanluker ryanluker ryanluker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@anishkny @ryanluker