fix(preview): pass vscode.uri to live preview #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes ryanluker#381 convert file path string to vscode.Uri to support changes in live preview resovles the exception mentioned in microsoft/vscode-livepreview#384
|
@kaltepeter Thanks for the PR! |
ryanluker
reviewed
Feb 25, 2023
| const coverage = new Coverage( | ||
| stubConfig, | ||
| ); | ||
|
|
||
| const value = await coverage.pickFile(["123"], "nope"); | ||
| expect(value).to.equal("123"); | ||
| expect(value?.path).to.equal("/123"); |
There was a problem hiding this comment.
Thanks for fixing the tests as well!
Looks like everything is passing here 🦾.
https://github.com/ryanluker/vscode-coverage-gutters/actions/runs/4270550605/jobs/7434653819
ryanluker
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Changes:
livePreview.start.preview.atFilewith an argument microsoft/vscode-livepreview#384