Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jacoco aggregate #405

Merged
merged 5 commits into from
May 22, 2023

Conversation

7sean68
Copy link
Contributor

@7sean68 7sean68 commented May 6, 2023

closes #401

@7sean68 7sean68 mentioned this pull request May 6, 2023
package.json Outdated Show resolved Hide resolved
@@ -219,6 +219,45 @@ suite("Extension Tests", function() {
decorationSpy.restore();
});

test("Run display coverage on java files from jacoco-aggregate report @integration", async () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks a ton for adding tests 👍🏻.

@ryanluker
Copy link
Owner

@7sean68 We might want to add "Multi-Module Java" to the example projects list in the README.
https://github.com/ryanluker/vscode-coverage-gutters#officially-supported-languages-backed-by-tests-ran-nightly

Co-authored-by: Ryan Luker <ryanluker@outlook.com>
@7sean68
Copy link
Contributor Author

7sean68 commented May 6, 2023

can you please not merge it now?

@7sean68
Copy link
Contributor Author

7sean68 commented May 6, 2023

something I need to check first

@ryanluker
Copy link
Owner

something I need to check first

Sure thing, I have just need hitting the "approve and run" button to get the CI workflow to run for yeah.

@7sean68 7sean68 marked this pull request as draft May 6, 2023 18:13
@7sean68 7sean68 marked this pull request as ready for review May 11, 2023 13:18
@7sean68
Copy link
Contributor Author

7sean68 commented May 11, 2023

I added the example to readme.
I also added a notice to the copied test files from an Apache repo can you check if everything is ok?
It's ready now you can merge if everything is ok. Thanks for the wait 😄

@ryanluker
Copy link
Owner

I added the example to readme. I also added a notice to the copied test files from an Apache repo can you check if everything is ok? It's ready now you can merge if everything is ok. Thanks for the wait 😄

Excellent, I will try to take a final look within the next week.

Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks again for the contribution 🦾 .
Re Apache license, the examples folder is not distributed with the extension into the vscode marketplace so the MIT license will still be good there, thanks for checking though!

@ryanluker ryanluker added this to the 2.11.0 milestone May 22, 2023
@ryanluker ryanluker merged commit 5a162d4 into ryanluker:master May 22, 2023
@7sean68
Copy link
Contributor Author

7sean68 commented May 22, 2023

I think Apache license is compatible with MIT license anyway. So, even if the example are shipped the notice is enough and it doesn't affect the whole repo being MIT ... BTW that's why I paused merging the first time. I had to contact the author of the repo as I discovered it wasn't licensed ... thankfully he added the license and I updated the files to add the notice to not cause any problems for the repo.

Thanks for the great work creating and maintaining this helpful project. I use it as a main extension in vscode for java development.

@ryanluker
Copy link
Owner

I think Apache license is compatible with MIT license anyway. So, even if the example are shipped the notice is enough and it doesn't affect the whole repo being MIT ... BTW that's why I paused merging the first time. I had to contact the author of the repo as I discovered it wasn't licensed ... thankfully he added the license and I updated the files to add the notice to not cause any problems for the repo.

Thanks for the great work creating and maintaining this helpful project. I use it as a main extension in vscode for java development.

Excellent, thanks for going that extra mile to get a license added!
Great to hear that the extension is providing value for your development work, mission accomplished!

Thanks again for the contribution, this helps keep the project running smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support jacoco aggregate
2 participants