-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support jacoco aggregate #405
Conversation
to support jacoco aggregate
@@ -219,6 +219,45 @@ suite("Extension Tests", function() { | |||
decorationSpy.restore(); | |||
}); | |||
|
|||
test("Run display coverage on java files from jacoco-aggregate report @integration", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks a ton for adding tests 👍🏻.
@7sean68 We might want to add "Multi-Module Java" to the example projects list in the README. |
Co-authored-by: Ryan Luker <ryanluker@outlook.com>
can you please not merge it now? |
something I need to check first |
Sure thing, I have just need hitting the "approve and run" button to get the CI workflow to run for yeah. |
I added the example to readme. |
Excellent, I will try to take a final look within the next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great thanks again for the contribution 🦾 .
Re Apache license, the examples folder is not distributed with the extension into the vscode marketplace so the MIT license will still be good there, thanks for checking though!
I think Apache license is compatible with MIT license anyway. So, even if the example are shipped the notice is enough and it doesn't affect the whole repo being MIT ... BTW that's why I paused merging the first time. I had to contact the author of the repo as I discovered it wasn't licensed ... thankfully he added the license and I updated the files to add the notice to not cause any problems for the repo. Thanks for the great work creating and maintaining this helpful project. I use it as a main extension in vscode for java development. |
Excellent, thanks for going that extra mile to get a license added! Thanks again for the contribution, this helps keep the project running smoothly. |
closes #401