Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics and config cleanup #44

Merged
merged 12 commits into from
Apr 9, 2017
Merged

Metrics and config cleanup #44

merged 12 commits into from
Apr 9, 2017

Conversation

ryanluker
Copy link
Owner

@ryanluker ryanluker commented Apr 7, 2017 •
edited
Loading

Issue: #43

Work:

  • add metrics reporter
  • wire up initial events
  • add opt out functionality
  • add more basic metrics like vscode version, and GA recommends
    https://support.google.com/analytics/answer/1033068?hl=en
  • add tests for opt out functionality
  • dependency inject uuid and request post for easier mocking
  • increment versions

QA:

  • confirm GA gets events
  • test on windows machine
  • test on mac machine

@ryanluker ryanluker self-assigned this Apr 7, 2017
@ryanluker ryanluker merged commit bebcf3b into master Apr 9, 2017
@ryanluker ryanluker deleted the 43-metrics branch April 9, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanluker ryanluker

Labels
None yet
Projects
None yet
Milestone
0.4.0 - Improved Customization
Development

Successfully merging this pull request may close these issues.
1 participant
@ryanluker