Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make bad and old examples more comparable #124

Merged
merged 1 commit into from
Jan 13, 2017
Merged

make bad and old examples more comparable #124

merged 1 commit into from
Jan 13, 2017

Conversation

vsemozhetbyt
Copy link
Contributor

See the comment of @ryanmcdermott.

With this PR:

  1. Bad and old examples become more comparable (let bad examples be bad only in regard to one appropriate case).
  2. Both examples do not contain type coercion (i.e. they use strict comparing).
  3. The new algorithm has less performance difference in small and large arrays comparing (some benchmarks have been done).

Also address performance concerns.
@ryanmcdermott ryanmcdermott merged commit a09a696 into ryanmcdermott:master Jan 13, 2017
@ryanmcdermott
Copy link
Owner

Even smaller, and probably faster time complexity! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants