Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When do we get our inverse U+E0B0 Triangle? #1451

Closed
3 tasks done
a-usr opened this issue Dec 5, 2023 · 8 comments · Fixed by #1490
Closed
3 tasks done

When do we get our inverse U+E0B0 Triangle? #1451

a-usr opened this issue Dec 5, 2023 · 8 comments · Fixed by #1490

Comments

@a-usr
Copy link

a-usr commented Dec 5, 2023

Requirements

  • I have searched the issues for my request and found nothing related and/or helpful
  • I have searched the FAQ for help
  • I have searched the Wiki for help

Is your feature request related to a problem? Please describe.
Some Terminals dont apply effects like transpaency to foreground colors.

Describe the solution you'd like
Inverted version of U+E0B0 and other powerline symbols without already existing inverse counterparts

Describe alternatives you've considered
U+E0D4: Looks bad

Additional context
This has been requested on multiple occasions, for example Here
Also, its not like the svg's have to be made from scrap, some already exist in the Powerline Extra Repo (here for example)

@Finii
Copy link
Collaborator

Finii commented Jan 17, 2024

Misunderstood initially, this is my first answer, maybe ignore

I guess I do not get it.
If you want to have it "inverse" just assign the foreground color to the background and vice versa?

You mean these two?

image

They are the same, just one time you turn on 'inverse mode' via \e[7m.

Usually it looks more like this:

image

The first E0B0 (left pink arrow) and its inverse twin E0B0 (right pink arrow). Just by setting the color correctly.

image

printf "\e[102m\e[31m fini \e[92m\e[100m\ue0b0\e[100m\e[97m ~ \e[90m\e[102m\ue0b0\e[31m test \e[0m\n"

With explanation:

image

You see, the left (first) E0B0 is green-on-grey and the right (second) inverse one is grey-on-green.

Here the real answer

Transparency mode?

Some Terminals dont apply effects like transpaency to foreground colors.

Which terminal is that, that you use for PowerShell?

I guess you mean this here ryanoasis/powerline-extra-symbols@eb6b972
Codepoints E0D6 and E0D7

image

image

@Finii
Copy link
Collaborator

Finii commented Jan 17, 2024

This is also merged by Ryan but missing because never released

ryanoasis/powerline-extra-symbols@aebf016

Codepoints E0C9 right-half-circle-thick-inverse-cutout and E0CB left-half-circle-thick-inverse-cutout

@Finii
Copy link
Collaborator

Finii commented Jan 19, 2024

Note to self:
Check if this is still a problem with Win11 (i.e. Windows Terminal)

@Finii
Copy link
Collaborator

Finii commented Jan 19, 2024

U+E0D4: Looks bad

Can you explain why? Looks bad for your use case, or is there an issue with the icon itself?

Finii added a commit that referenced this issue Jan 19, 2024
Fixes: #1451
Fixes: #7

See also (merged but not released):
ryanoasis/powerline-extra-symbols@eb6b972

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented Jan 19, 2024

Are you willing to test the new glyphs?
I can create patched fonts for your preferred sourcefont and you can try.
Please specify which font you'd like to test @a-usr.

@Finii Finii added this to the v3.2.0 milestone Jan 19, 2024
Finii added a commit that referenced this issue Jan 19, 2024
Fixes: #1451

See also (merged but not released):
ryanoasis/powerline-extra-symbols@eb6b972

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@a-usr
Copy link
Author

a-usr commented Jan 19, 2024

U+E0D4: Looks bad

Can you explain why? Looks bad for your use case, or is there an issue with the icon itself?

It's not the icon itself, but it just don't match with what I need in my use case (specifically the empty line in the middle and the fact that the angle of the triangle when the symbol has the background colour as foreground and vice versa)

Which terminal is that, that you use for PowerShell?

It is actually Windows Terminal, wich you plan on investigating.

Are you willing to test the new glyphs?
I can create patched fonts for your preferred sourcefont and you can try.
Please specify which font you'd like to test @a-usr.

I would love to test CascaydaCove

@Finii
Copy link
Collaborator

Finii commented Jan 20, 2024

I would love to test CascaydaCove

You can find that in the PR: #1490 (comment)

Please report back in the PR thread.

Finii added a commit that referenced this issue Mar 29, 2024
Fixes: #1451

See also (merged but not released):
ryanoasis/powerline-extra-symbols@eb6b972

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
hasecilu pushed a commit to hasecilu/nerd-fonts that referenced this issue Apr 3, 2024
Fixes: ryanoasis#1451

See also (merged but not released):
ryanoasis/powerline-extra-symbols@eb6b972

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants