Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Denite configuration to readme #205

Closed
7 tasks done
ryanoasis opened this issue May 13, 2017 · 4 comments
Closed
7 tasks done

Add missing Denite configuration to readme #205

ryanoasis opened this issue May 13, 2017 · 4 comments

Comments

@ryanoasis
Copy link
Owner

Required Info

  • I have searched the issues for my issue and found nothing related and/or helpful

  • I have read or at least glanced at the FAQ

  • I have read or at least glanced at the Wiki

  • What version of vim are you using? N/A

    • hint: vim --version
  • What version of vim-devicons are you using? 0.9.1

    • hint: :echo webdevicons#version()
  • Are you using vim from the terminal or a GUI vim? N/A

  • Are you using Mac, Linux or Windows? N/A

Implementation:

Add a Denite section just like we have for unite:

" adding the custom source to denite 
let g:webdevicons_enable_denite = 1

see for example: https://github.com/ryanoasis/vim-devicons/blame/master/readme.md#L308-L311

@mohamadLy
Copy link
Contributor

I can take it, if it's ok with you.

mohamadLy added a commit to mohamadLy/vim-devicons that referenced this issue Dec 6, 2017
@ryanoasis
Copy link
Owner Author

@mohamadLy Thanks! sure it's all yours 😄

@mohamadLy
Copy link
Contributor

@ryanoasis thanks for giving the chance. I've opened a PR for it. Any feedback is welcome as this is my first time.

@ryanoasis ryanoasis added this to the v0.10.0 milestone Jan 21, 2018
@ryanoasis
Copy link
Owner Author

Closed/fixed via PR #217. Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants