-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor documentations and remove unnecessary parts #232
Conversation
@kutsan Thanks for PR and it will take me a while to digest this 100%, some of these changes I am definitely for and others I am definitely against (at least at this time).
For sure yep, but even my ideas are subjective and if we are not open to others ideas then that would be silly 😄 . Yes I think these changes will take some talking and meeting in the middle on certain things. Overall I see what you are getting at mainly, it is overly verbose to the point of main points being useless or not helpful and making it hard to find higher level important aspects. I really appreciate your effort, ideas, changes. Even if we don't end up including even most of them I think this is very helpful in the long run. Cheers |
Thanks! I'm very glad it's helpful for you. By the way, I am also kind of mad about how https://github.com/ryanoasis/nerd-fonts is also verbose. 😅 |
Haha I bet! Well I try to be open to any suggestions and I will take any constructive criticism to heart. A bug theme of offloading things from the readme to the wiki would be a good start. I've started to do that more but still a ways to go. I've been fairly busy working on Nerd Fonts but do switch back to VimDevIcons when I can. |
So, here is the TODO list for this PR. Feel free to edit this message.
|
@kutsan I did recently do a logo refresh.. so you'll have to rebase or update your branch. Can you tell me if you plan on doing offloading to the wiki? If not I will take up that task 😄 |
I updated my branch accordingly. Also, I don't have any plan about wiki, sorry. |
@kutsan Thanks. I will tackle the wiki. |
4- Do you think it's still needed to have, since README is pretty short now? If you think it's needed, I'm going to add it. |
@kutsan Side note: |
4- Yes, I agree. Resolved conflict and now I guess we are done. Also, thanks for invitation, I appreciate it! Although I don't know what to do with. xD |
You're welcome. Haha. I understand 😄 |
That's a lot of better now. We made a significant improvement. 😆 |
@kutsan I agree, thank you for the work and ideas. I am mostly very pleased with the results, a few things you suggested didn't make it, a few things I might tweak but overall and for now it is looking nice 😄 |
Quick link: https://github.com/kutsan/vim-devicons
changelog.md
→CHANGELOG.md
as convention.README.md
toDEVELOPER.md
, again as convention.Table of Contents
andQuick Links
section because now we don't need that, since it's short file.style=flat-square
format, instead ofstyle=for-the-badge
. That was becausefor-the-badge
doesn't look modern, it's plumpy, besides it's 2018. :(align="center"
.Rationale
section because it was useless. (Sorry, I have to say that.)let g:airline_powerline_fonts = 1
section because it needs to be automatic process. You need to check if airline installed, if it's, then set that to1
, no need to say for that.vimrc examples
, it was useless.Extra Configuration
section because there is no space for that. If they want to learn how configure, they need to use:help devicons
. I added a quote for that. Please, support this approach, having ~200 lines of how to configure section in README is no good.Usage
section because it was useless. Plugin works (and should) out of the box.Contributing
section more pleasant.Created this PR because README was cluttered for newcomers. Even I sometimes struggle to find something. I made it short and readable for everyone. Some of my changes was subjective, we can talk about more to how to properly structure them.