use document.importNode
for when img/iframe
use loading="lazy"
#349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to reuse the same logic as
hasCustomElement
as anisImportNode
. That currently only becomestrue
when animage/iframe
has the attributeloading="lazy"
To solve solidjs/solid#1828 avoiding using
document.importNode
for every other element.This in theory should have worked on the first try. For some reason nested elements with such an attribute won't be marked as
isImportNode
. Handled this oddity with a least resort regexp for now._$template('<img src=""loading=lazy>', true, false),
_$template('<div><img src=""loading=lazy>', true, false);
Without the regexp the last one won't have
true, false)