enable deletion of resource if job is complete (aws-controllers-k8s#16)

- enable deletion of resource if job is complete
- reduce custom code by using callback hooks

generator.yaml

@@ -1,24 +1,24 @@
 operations:
 <<<<<<< HEAD
+<<<<<<< HEAD
 =======
   CreateTrainingJob:
     set_output_custom_method_name: customCreateTrainingJobSetOutput
 >>>>>>> 5eb5b19 (Add Requeue logic for Job Style resources till completion (#10))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
   DescribeTrainingJob:
     set_output_custom_method_name: customDescribeTrainingJobSetOutput
   StopTrainingJob:
     operation_type: Delete
     resource_name: TrainingJob
-  CreateProcessingJob:
-    set_output_custom_method_name: customCreateProcessingJobSetOutput
-  DescribeProcessingJob:
-    set_output_custom_method_name: customDescribeProcessingJobSetOutput
   StopProcessingJob:
     operation_type: Delete
     resource_name: ProcessingJob
 <<<<<<< HEAD
 <<<<<<< HEAD
 <<<<<<< HEAD
+<<<<<<< HEAD
 =======
   CreateTransformJob:
     set_output_custom_method_name: customCreateTransformJobSetOutput
@@ -37,6 +37,11 @@ operations:
   CreateEndpoint:
     set_output_custom_method_name: customCreateEndpointSetOutput
 >>>>>>> 03f0cbe (Introduce endpointconfig and endpoint controller)
+=======
+  StopTransformJob:
+    operation_type: Delete
+    resource_name: TransformJob
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
   DescribeEndpoint:
     set_output_custom_method_name: customDescribeEndpointSetOutput
   UpdateEndpoint:
@@ -50,10 +55,6 @@ operations:
       RetainAllVariantProperties: true
   DeleteEndpoint:
     custom_implementation: customDeleteEndpoint
-  CreateHyperParameterTuningJob:
-    set_output_custom_method_name: customCreateHyperParameterTuningJobSetOutput
-  DescribeHyperParameterTuningJob:
-    set_output_custom_method_name: customDescribeHyperParameterTuningJobSetOutput
   StopHyperParameterTuningJob:
     operation_type: Delete
     resource_name: HyperParameterTuningJob
@@ -151,6 +152,7 @@ resources:
         - MalformedQueryString
         - InvalidAction
         - UnrecognizedClientException
+<<<<<<< HEAD
 <<<<<<< HEAD
         # Custom error
         - EndpointUpdateError
@@ -161,6 +163,11 @@ resources:
 >>>>>>> 03f0cbe (Introduce endpointconfig and endpoint controller)
 =======
 >>>>>>> 5ccff0e (Adding Terminal Conditions (#12))
+=======
+    hooks:
+      sdk_create_post_set_output:
+        code: rm.customSetOutput(r, aws.String(svcsdk.EndpointStatusCreating), ko)
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     fields:
       EndpointStatus:
         is_read_only: true
@@ -252,13 +259,19 @@ resources:
         - InvalidAction
         - UnrecognizedClientException
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     hooks:
       sdk_create_post_set_output:
         code: rm.customSetOutput(r, aws.String(svcsdk.TrainingJobStatusInProgress), ko)
       sdk_delete_pre_build_request:
         template_path: training_job/sdk_delete_pre_build_request.go.tpl
+<<<<<<< HEAD
 =======
 >>>>>>> 5ccff0e (Adding Terminal Conditions (#12))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     fields:
       TrainingJobStatus:
           is_read_only: true
@@ -304,15 +317,21 @@ resources:
         - InvalidAction
         - UnrecognizedClientException
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     hooks:
       sdk_delete_pre_build_request:
         template_path: processing_job/sdk_delete_pre_build_request.go.tpl
       sdk_create_post_set_output:
         code: rm.customSetOutput(r, aws.String(svcsdk.ProcessingJobStatusInProgress), ko)
       sdk_read_one_post_set_output:
         code: rm.customSetOutput(r, resp.ProcessingJobStatus, ko)
+<<<<<<< HEAD
 =======
 >>>>>>> 5ccff0e (Adding Terminal Conditions (#12))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     fields:
       ProcessingJobStatus:
         is_read_only: true
@@ -351,17 +370,23 @@ resources:
         - InvalidAction
         - UnrecognizedClientException
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     hooks:
       sdk_delete_pre_build_request:
         template_path: transform_job/sdk_delete_pre_build_request.go.tpl
       sdk_create_post_set_output:
         code: rm.customSetOutput(r, aws.String(svcsdk.TransformJobStatusInProgress), ko)
       sdk_read_one_post_set_output:
         code: rm.customSetOutput(r, resp.TransformJobStatus, ko)
+<<<<<<< HEAD
 =======
 >>>>>>> 5e70629 (Adding Transform Job (#4))
 =======
 >>>>>>> 5ccff0e (Adding Terminal Conditions (#12))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     fields:
       TransformJobStatus:
           is_read_only: true
@@ -403,17 +428,23 @@ resources:
         - InvalidAction
         - UnrecognizedClientException
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     hooks:
       sdk_delete_pre_build_request:
         template_path: hyper_parameter_tuning_job/sdk_delete_pre_build_request.go.tpl
       sdk_create_post_set_output:
         code: rm.customSetOutput(r, aws.String(svcsdk.HyperParameterTuningJobStatusInProgress), ko)
       sdk_read_one_post_set_output:
         code: rm.customSetOutput(r, resp.HyperParameterTuningJobStatus, ko)
+<<<<<<< HEAD
 =======
 >>>>>>> d40a0ca (HyperParameterJob controller (#5))
 =======
 >>>>>>> 5ccff0e (Adding Terminal Conditions (#12))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
     fields:
       HyperParameterTuningJobStatus:
         is_read_only: true

pkg/resource/endpoint/custom_set_output.go

@@ -26,6 +26,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 )
 
+<<<<<<< HEAD
 <<<<<<< HEAD
 // customDescribeEndpointSetOutput sets the resource ResourceSynced condition to False if endpoint is
 =======
@@ -43,6 +44,9 @@ func (rm *resourceManager) customCreateEndpointSetOutput(
 
 // customDescribeEndpointSetOutput sets the resource in TempOutofSync if endpoint is
 >>>>>>> 03f0cbe (Introduce endpointconfig and endpoint controller)
+=======
+// customDescribeEndpointSetOutput sets the resource ResourceSynced condition to False if endpoint is
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 // being modified by AWS
 func (rm *resourceManager) customDescribeEndpointSetOutput(
 	ctx context.Context,
@@ -79,8 +83,12 @@ func (rm *resourceManager) customDescribeEndpointSetOutput(
 	return ko, nil
 }
 
+<<<<<<< HEAD
 // customUpdateEndpointSetOutput sets the resource in TempOutofSync if endpoint is
 >>>>>>> 03f0cbe (Introduce endpointconfig and endpoint controller)
+=======
+// customUpdateEndpointSetOutput sets the resource ResourceSynced condition to False if endpoint is
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 // being updated. At this stage we know call to updateEndpoint was successful.
 func (rm *resourceManager) customUpdateEndpointSetOutput(
 	ctx context.Context,

pkg/resource/hyper_parameter_tuning_job/custom_set_output.go

@@ -17,6 +17,7 @@
 package hyper_parameter_tuning_job
 
 import (
+<<<<<<< HEAD
 <<<<<<< HEAD
 	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
 	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
@@ -27,10 +28,15 @@ import (
 	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
 	"github.com/aws/aws-sdk-go/aws"
 >>>>>>> 5eb5b19 (Add Requeue logic for Job Style resources till completion (#10))
+=======
+	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
+	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 	svcsdk "github.com/aws/aws-sdk-go/service/sagemaker"
 	corev1 "k8s.io/api/core/v1"
 )
 
+<<<<<<< HEAD
 <<<<<<< HEAD
 =======
 // customCreateHyperParameterTuningJobSetOutput sets the resource in TempOutofSync if HyperParameterTuningJob is
@@ -58,6 +64,8 @@ func (rm *resourceManager) customDescribeHyperParameterTuningJobSetOutput(
 }
 
 >>>>>>> 5eb5b19 (Add Requeue logic for Job Style resources till completion (#10))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 // customSetOutput sets ConditionTypeResourceSynced condition to True or False
 // based on the hyperParameterTuningJobStatus on AWS so the reconciler can determine if a
 // requeue is needed

pkg/resource/processing_job/custom_set_output.go

@@ -17,6 +17,7 @@
 package processing_job
 
 import (
+<<<<<<< HEAD
 <<<<<<< HEAD
 	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
 	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
@@ -27,10 +28,15 @@ import (
 	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
 	"github.com/aws/aws-sdk-go/aws"
 >>>>>>> 5eb5b19 (Add Requeue logic for Job Style resources till completion (#10))
+=======
+	ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
+	svcapitypes "github.com/aws-controllers-k8s/sagemaker-controller/apis/v1alpha1"
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 	svcsdk "github.com/aws/aws-sdk-go/service/sagemaker"
 	corev1 "k8s.io/api/core/v1"
 )
 
+<<<<<<< HEAD
 <<<<<<< HEAD
 =======
 // customCreateProcessingJobSetOutput sets the resource in TempOutofSync if ProcessingJob is
@@ -58,6 +64,8 @@ func (rm *resourceManager) customDescribeProcessingJobSetOutput(
 }
 
 >>>>>>> 5eb5b19 (Add Requeue logic for Job Style resources till completion (#10))
+=======
+>>>>>>> 3c1fc55 (enable deletion of resource if job is complete (#16))
 // customSetOutput sets ConditionTypeResourceSynced condition to True or False
 // based on the processingJobStatus on AWS so the reconciler can determine if a
 // requeue is needed