Update flake outputs structure in line with current specification #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: this commit removes several flake outputs which have been marked as deprecated upstream for quite a while: - `nixosModule` -> `nixosModules.default` - `overlay` -> `overlays.default` - `defaultPackage.<system>` -> `packages.<system>.default`
montchr
force-pushed
the
flake-outputs-current
branch
from
453da4b
to
49af60e
Compare
|
#127 should be merged before this, since the deprecation warnings are not exposed on 21.11 |
ryantm
requested changes
Oct 15, 2022
| }; | ||
| flake.overlays.default = final: prev: { | ||
| agenix = prev.callPackage ./pkgs/agenix.nix {}; | ||
| }; |
There was a problem hiding this comment.
I do not want to use complex constructions and external libraries to save 10 lines of boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
flake.nixhas a lot of system-scoping boilerplate repetition which is oftentimes reduced in flakes by way of theflake-utilslibrary or, lately, theflake-partslibrary. It is also certainly possible to do so usingnixpkgs.libbut the third-party libraries can provide some additional stability if the flakes output API changes again.A related issue is that the current flake outputs are lagging behind the current flakes specification, which results in an unintuitive usage by flake consumers, as well as a bunch of deprecation warnings.
This pull request would introduce the renaming of the following outputs as follows:
nixosModule->nixosModules.defaultoverlay->overlays.defaultdefaultPackage.<system>->packages.<system>.defaultAs a result, this will be a breaking change. But that's the nature of using an experimental feature, and the deprecation has been clear for a while.