Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: format with Alejandra #137

Merged
merged 2 commits into from
Jan 29, 2023
Merged

contrib: format with Alejandra #137

merged 2 commits into from
Jan 29, 2023

Conversation

ryantm
Copy link
Owner

@ryantm ryantm commented Jan 29, 2023 •
edited by cole-h
Loading

  • Add new contributing docs
  • Choose Alejandra as Nix formatter
  • Add formatter to flake so nix fmt works
  • Add CI lint step for nix fmt checking
  • Format all nix files

Depends on #136

@ryantm ryantm requested a review from cole-h January 29, 2023 19:14
cole-h
cole-h approved these changes Jan 29, 2023
View reviewed changes
Copy link
Collaborator

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably create a lot of merge conflicts. Not that that's necessarily a problem, but something to be aware of.

Generally ambivalent towards the choice of formatter as well, but implementation looks fine.

@ryantm ryantm merged commit 6d3a415 into main Jan 29, 2023
@ryantm ryantm deleted the rtm-1-30-nix-format branch February 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryantm @cole-h