contrib: use mkDerivation for agenix cli #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
force-pushed
the
rtm-1-29-cli-test
branch
2 times, most recently
from
0ad4e72
to
278528b
Compare
ryantm
changed the title
ryantm
force-pushed
the
rtm-1-29-cli-test
branch
3 times, most recently
from
9ac24cf
to
8fb773a
Compare
|
Maybe use |
* use mkDerivation * separate shell code in own file * use shellcheck to lint shell code * remove rage version check since rage is greater than 0.5.0 on all maintained nixpkgs
It looks like that makes it annoying to add meta information and a version. |
ryantm
force-pushed
the
rtm-1-29-cli-test
branch
from
8fb773a
to
d0b75dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to move toward a world where we test the agenix cli. I feel this is a reasonable organizational step, so we can separate the nix code from the bash code.