-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: try to add nix-darwin support #141
Conversation
Merges work by @montchr, @cmhamill, and @rtimush and rebases on main. - fixes ryantm#60 - fixes ryantm#120 - closes ryantm#107
Yay passing tests! I don't have a system to try this on. If you do, please chime in if it works for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code overall looks good to me and I'm basically ready to merge. I tested the integration test fails if I expect a different decrypted file contents.
It would be nice to get one more nix-darwin user to sanity check this before merging, but if we don't get one by the end of the week lets
I'll capture that output, good point. Will do a little more testing this morning. |
Few minor changes incoming. |
@n8henrie I know almost nothing about MacOS file systems. I haven't used a Mac for over 16 years. Maybe you can ping the other people that were trying to get nix-darwin support? |
Looks like using |
This reverts commit 4c315d9.
Integration tests are now failing, I think due to removal of the activation scripts. EDIT: Nope, passing now and without the activation scripts. |
…e weird number after ram://
Gah, older macos doesn't like the |
Ok, I think this is ready to merge (would be great if 1 more nix-darwin user can pull and test). Tests passing, working on reboot with my system. |
@rtimush up for another try? |
Tried and everything worked fine for me 👍 |
Merges work by @montchr, @cmhamill, and @rtimush and rebases on main.
system.activationScripts.users.deps
does not exist #60darwinModules
for use withnix-darwin
#120