Snyn fork #2
Merged
Snyn fork #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to the -cvlan capability that knife-vsphere gives you. == DETAILS -Added a new configuration option 'vlan' that lets you specify the vlan string -If vlan is set, the clone spec is modified with an edit action to connect the first NIC on the VM to the configured VLAN.
Updates README.md
Add vlan option to README
-If the VM is powered on, then it is powered off, and destroyed. -If the VM is powered off, it is just destroyed. -If the VM is suspended, it is powered on, then powered off, then destroyed. -This feels weird, but the vsphere API docs state that calling power off on a vm in any other state besides poweredOn will throw an exception. -Also, the Destroy_Task documentation and the VirtualMachine documentation don't specify what state the VM has to be in before it is destroyed. -Since the current implementation tries to make sure it is powered off before it is destroyed, I am making sure to do the same if the VM is suspended. == DETAILS -I refactored the VM state stuff into a common module called VmHelpers. The get_state action now uses this for getting the machine state, and most of the common vm tasks are wrapped by this class. -Basically what we are doing here is making the power_off action idempotent, and I toyed with the idea of making idempotent wrapper methods in VmHelpers, but decided that VmHelpers should just deal with interacting with the VM and let the actions themselves enforce idempotency if they wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.