Merge pull request #402 from ryohey/fix-export-black-midi

Fix export black midi
ryohey · Sep 10, 2024 · 45ff781 · 45ff781
2 parents bd23262 + ae41529
commit 45ff781
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/app/src/actions/selection.ts b/app/src/actions/selection.ts
@@ -1,4 +1,4 @@
-import { min } from "lodash"
+import { max, min } from "lodash"
 import {
   PianoNotesClipboardData,
   isPianoNotesClipboardData,
@@ -330,8 +330,8 @@ export const duplicateSelection =
       .filter(isNoteEvent)
 
     if (deltaTick === 0) {
-      const left = Math.min(...selectedNotes.map((n) => n.tick))
-      const right = Math.max(...selectedNotes.map((n) => n.tick + n.duration))
+      const left = min(selectedNotes.map((n) => n.tick)) ?? 0
+      const right = max(selectedNotes.map((n) => n.tick + n.duration)) ?? 0
       deltaTick = right - left
     }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/community/src/track/Track.ts b/packages/community/src/track/Track.ts
@@ -1,3 +1,4 @@
+import { max } from "lodash"
 import { AnyEvent } from "midifile-ts"
 import { DistributiveOmit } from "../types.js"
 
@@ -13,5 +14,5 @@ export interface Track {
 }
 
 export function getEndOfTrack(events: TrackEvent[]) {
-  return Math.max(...events.map((event) => event.tick)) || 0
+  return max(events.map((event) => event.tick)) ?? 0
 }
diff --git a/packages/player/package.json b/packages/player/package.json
@@ -24,6 +24,6 @@
     "typescript": "^5.4.5"
   },
   "dependencies": {
-    "@ryohey/wavelet": "^0.7.3"
+    "@ryohey/wavelet": "^0.7.4"
   }
 }