Fix note resizing behavior #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was occurring in the ability to resize multiple notes at the same time when in pencil mode. While fixing this, the handling of moving and resizing notes and selections has been overhauled.
PianoRollDraggableThe left, center, and right ends of notes and the left, center, and right ends of selections are represented by the concept
PianoRollDraggable, respectively. ThePianoRollDraggablecan be retrieved and updated from the PianoRollStore.For example, an operation that changes the length of a note by dragging its right edge corresponds to moving the PianoRollDraggable on the right edge of the note.
moveDraggableActionMove operations are unified into
moveDraggableAction. ThemoveDraggableActionallows you to move thePianoRollDraggableyou want to move, and multiplePianoRollDraggablesassociated with it, simultaneously by dragging. EachPianoRollDraggablehas its own movement limit, and the range of movement is adjusted according to the position of the selected notes, etc. to prevent inappropriate movement.Temporary quantization disablement
Also, while it has been possible to temporarily disable quantize by pressing the Shift key when adjusting note size, I have added this functionality to
moveDraggableActionso that quantize can be disabled by pressing the Shift key during any move or resize.