Air Humidifier: Add set_led method (#451)

* Air Humidifier: Add set_led method * Fix tests
rytilahti · Jan 9, 2019 · 474b1d1 · 474b1d1
1 parent 2774aa5
commit 474b1d1
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 0 deletions.
diff --git a/miio/airhumidifier.py b/miio/airhumidifier.py
@@ -340,6 +340,20 @@ def set_led_brightness(self, brightness: LedBrightness):
 
         return self.send("set_led_b", [brightness.value])
 
+    @command(
+        click.argument("led", type=bool),
+        default_output=format_output(
+            lambda led: "Turning on LED"
+            if led else "Turning off LED"
+        )
+    )
+    def set_led(self, led: bool):
+        """Turn led on/off."""
+        if led:
+            return self.set_led_brightness(LedBrightness.Bright)
+        else:
+            return self.set_led_brightness(LedBrightness.Off)
+
     @command(
         click.argument("buzzer", type=bool),
         default_output=format_output(

diff --git a/miio/tests/test_airhumidifier.py b/miio/tests/test_airhumidifier.py
@@ -147,6 +147,16 @@ def led_brightness():
         self.device.set_led_brightness(LedBrightness.Off)
         assert led_brightness() == LedBrightness.Off
 
+    def test_set_led(self):
+        def led_brightness():
+            return self.device.status().led_brightness
+
+        self.device.set_led(True)
+        assert led_brightness() == LedBrightness.Bright
+
+        self.device.set_led(False)
+        assert led_brightness() == LedBrightness.Off
+
     def test_set_buzzer(self):
         def buzzer():
             return self.device.status().buzzer
@@ -343,6 +353,16 @@ def led_brightness():
         self.device.set_led_brightness(LedBrightness.Off)
         assert led_brightness() == LedBrightness.Off
 
+    def test_set_led(self):
+        def led_brightness():
+            return self.device.status().led_brightness
+
+        self.device.set_led(True)
+        assert led_brightness() == LedBrightness.Bright
+
+        self.device.set_led(False)
+        assert led_brightness() == LedBrightness.Off
+
     def test_set_buzzer(self):
         def buzzer():
             return self.device.status().buzzer