Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xiaomi Humidifier CA4 fail to read status. (zhimi.humidifier.ca4) #908

Closed
tierman opened this issue Jan 12, 2021 · 0 comments · Fixed by #971
Closed

Xiaomi Humidifier CA4 fail to read status. (zhimi.humidifier.ca4) #908

tierman opened this issue Jan 12, 2021 · 0 comments · Fixed by #971
Assignees
@syssi
Labels
bug

Comments

@tierman
Copy link

tierman commented Jan 12, 2021

In file airhumidifier_miot.py in class AirHumidifierMiotStatus is a string builder with self.fault - unresolved reference.

Probably You can add property:

@property
def fault(self) -> int:
    """Return fault code."""
    return self.data["fault"]

and resolve this issue.
@tierman tierman added the bug label Jan 12, 2021
@syssi syssi self-assigned this Jan 13, 2021
syssi added a commit to syssi/python-miio that referenced this issue Jan 13, 2021
@syssi
Fix __repr__ of AirHumidifierMiotStatus (Closes: rytilahti#908)
e30e122
@syssi syssi closed this as completed in 9c57999 Jan 13, 2021
rytilahti pushed a commit that referenced this issue Jan 13, 2021
@syssi
Improve miottemplate.py print to support python 3.7.3 (Closes: #906) (#…
7771f45 
…910)

* Fix __repr__ of AirHumidifierMiotStatus (Closes: #908)

* Improve miottemplate.py print to support python 3.7.3
@rytilahti rytilahti mentioned this issue Mar 13, 2021
Merged
xvlady pushed a commit to xvlady/python-miio that referenced this issue May 9, 2021
@syssi @xvlady
Fix __repr__ of AirHumidifierMiotStatus (Closes: rytilahti#908) (ryti…
c8a4dfc 
…lahti#909)
xvlady pushed a commit to xvlady/python-miio that referenced this issue May 9, 2021
@syssi @xvlady
Improve miottemplate.py print to support python 3.7.3 (Closes: rytila…
350a551 
…hti#906) (rytilahti#910)

* Fix __repr__ of AirHumidifierMiotStatus (Closes: rytilahti#908)

* Improve miottemplate.py print to support python 3.7.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syssi syssi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prepare 0.5.5 rytilahti/python-miio
2 participants
@syssi @tierman