Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home() for Roborock S7 #1050

Merged
merged 2 commits into from
May 20, 2021
Merged

Fix home() for Roborock S7 #1050

merged 2 commits into from
May 20, 2021

Conversation

hebgit
Copy link
Contributor

@hebgit hebgit commented May 20, 2021

This fixes #918 for Roborock S7 by skipping app_pause as with Roborock S50 and S6 MaxV

This fixes #32315 for Roborock S7
@hebgit hebgit changed the title Fix #32315 for Roborock S7 Fix #918 for Roborock S7 May 20, 2021
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the skip is the default for other vacuums besides the v1, so could you please inverse the check (i.e., only call the pause on v1 vacuums)?

@hebgit
Copy link
Contributor Author

hebgit commented May 20, 2021

@rytilahti Like this?

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, thanks a lot! 👍

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.45%. Comparing base (f3f9550) to head (812df21).
Report is 386 commits behind head on master.

Files Patch % Lines
miio/vacuum.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1050   +/-   ##
=======================================
  Coverage   75.45%   75.45%           
=======================================
  Files          73       73           
  Lines        8357     8357           
  Branches      743      743           
=======================================
  Hits         6306     6306           
  Misses       1868     1868           
  Partials      183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti changed the title Fix #918 for Roborock S7 Fix home() for Roborock S7 May 20, 2021
@rytilahti rytilahti merged commit dd0124c into rytilahti:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Roborock S6 MaxV] Need a delay between pause and charge commands to return to dock
3 participants