Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceInfo refactor, do not crash on missing fields #1083

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jun 24, 2021

Fixes #1082

* Move the implementation to its own module
* Add ip_address and token properties
* Add tests
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.47%. Comparing base (a377d76) to head (a275c9d).
Report is 376 commits behind head on master.

Files Patch % Lines
miio/deviceinfo.py 83.87% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   75.40%   75.47%   +0.07%     
==========================================
  Files          73       74       +1     
  Lines        8367     8367              
  Branches      745      741       -4     
==========================================
+ Hits         6309     6315       +6     
+ Misses       1874     1870       -4     
+ Partials      184      182       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti changed the title DeviceInfo refactor, do not crash on invalid inputs DeviceInfo refactor, do not crash on missing fields Jun 24, 2021
@rytilahti
Copy link
Owner Author

Merging as this should not break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viomi S9 does not expose hv_wer
2 participants