Load power of the PowerStrip fixed and removed from the Plug #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
syssi
commented
Nov 8, 2017
syssi
commented
- Property load_power removed from the plug. It's a feature of the PowerStrip. The Xiaomi plug doesn't provide load.
- Load power workaround of the PowerStrip replaced by a property called "power_consume_rate" which provides the same values as the android app.
houndci-bot
reviewed
Nov 8, 2017
miio/powerstrip.py
Outdated
| @@ -61,7 +66,7 @@ class PowerStrip(Device): | |||
|
|
|||
| def status(self) -> PowerStripStatus: | |||
| """Retrieve properties.""" | |||
| properties = ['power', 'temperature', 'current', 'mode'] | |||
| properties = ['power', 'temperature', 'current', 'mode', 'power_consume_rate'] | |||
…rStrip. The Xiaomi plug doesn't provide load. Load power workaround of the PowerStrip replaced by a property called "power_consume_rate" which provides the same values as the android app.
syssi
force-pushed
the
feature/powerstrip-power-consume-rate
branch
from
7da0280 to
44358b7
Compare
Unittest of the Plug updated.
houndci-bot
reviewed
Nov 19, 2017
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] | ||
| assert self.state().load_power == self.device.start_state["power_consume_rate"] |
There was a problem hiding this comment.
line too long (87 > 79 characters)
| self.device._reset_state() | ||
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] |
There was a problem hiding this comment.
line too long (81 > 79 characters)
houndci-bot
reviewed
Nov 19, 2017
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] | ||
| assert self.state().load_power == self.device.start_state["power_consume_rate"] |
There was a problem hiding this comment.
line too long (87 > 79 characters)
| self.device._reset_state() | ||
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] |
There was a problem hiding this comment.
line too long (81 > 79 characters)
houndci-bot
reviewed
Nov 19, 2017
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] | ||
| assert self.state().load_power == self.device.start_state["power_consume_rate"] |
There was a problem hiding this comment.
line too long (87 > 79 characters)
| self.device._reset_state() | ||
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == self.device.start_state["temperature"] |
There was a problem hiding this comment.
line too long (81 > 79 characters)
houndci-bot
reviewed
Nov 19, 2017
miio/tests/test_powerstrip.py
Outdated
| assert self.state().temperature == \ | ||
| self.device.start_state["temperature"] | ||
| assert self.state().load_power == \ | ||
| self.device.start_state["power_consume_rate"] |
There was a problem hiding this comment.
continuation line over-indented for visual indent
miio/tests/test_powerstrip.py
Outdated
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == \ | ||
| self.device.start_state["temperature"] |
There was a problem hiding this comment.
continuation line over-indented for visual indent
houndci-bot
reviewed
Nov 19, 2017
miio/tests/test_powerstrip.py
Outdated
| assert self.state().temperature == \ | ||
| self.device.start_state["temperature"] | ||
| assert self.state().load_power == \ | ||
| self.device.start_state["power_consume_rate"] |
There was a problem hiding this comment.
continuation line over-indented for visual indent
miio/tests/test_powerstrip.py
Outdated
|
|
||
| assert self.is_on() is True | ||
| assert self.state().temperature == \ | ||
| self.device.start_state["temperature"] |
There was a problem hiding this comment.
continuation line over-indented for visual indent
|
Yay for coverage increase too, thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.