Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t require typing with Python 3.5 and newer #123

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Don’t require typing with Python 3.5 and newer #123

merged 1 commit into from
Nov 18, 2017

Conversation

pluehne
Copy link
Contributor

@pluehne pluehne commented Nov 18, 2017

Python 3.5 and newer ship with built-in typing support. For this reason, there is no need to require the typing package starting from Python 3.5.

On Arch Linux, this requirement caused trouble, because Arch Linux doesn’t provide the typing package anymore, as it is deemed unnecessary now. For this reason, python-miio complains about the missing typing dependency without this adjustment.

Python 3.5 and newer ship with built-in typing support. For this reason,
there is no need to require the typing package starting from Python 3.5.
@coveralls
Copy link

coveralls commented Nov 18, 2017

Coverage Status

Coverage remained the same at 44.98% when pulling 5077da5 on pluehne:patrick/python-3.5 into 62e82aa on rytilahti:master.

@rytilahti
Copy link
Owner

Looks good and reasonable, adding that requirement so hastily (and keeping support for py < 3.5) was not properly motivated choice. I think it would actually be fair enough to drop support for py < 3.5 considering Debian stable is also already on it, but let's leave it like that for the time being and merge this. Thanks!

@rytilahti rytilahti closed this Nov 18, 2017
@rytilahti rytilahti reopened this Nov 18, 2017
@rytilahti rytilahti merged commit 5f4e8b1 into rytilahti:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants