-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary support for managing sound files #154
Conversation
rytilahti
commented
Jan 5, 2018
- Adds install_sound which expects url, md5sum and id
- Adds printing of current sound volume to sound output.
Adds install_sound which expects url, md5sum and id
Requires testing & updating the docs accordingly, an open question is what should be used as a "id" (the current one can be queried with 'sound') for newly installed ones. Another open question is how to switch between languages without doing a "full" installation. |
* sound_install works now, displays installation state during installation * SoundInstallStatus and SoundStatus are new sound-related containers * get_sound_volume returns now an integer, requires a recent FW
I think this can be merged now, I just tested out generating an audio pack and then installing it afterwards. To simplify the process, the server functionality worked in #153 will be used by this functionality when its done. To add to the earlier comments by myself, looks like the id can be chosen as you wish (however, passing e.g. 0 gives an error). Furthermore, there seems to be no way to change the sound pack without a download; spamming sids will likely cause filling up the hard drive of the robot. |