Modified to support zoned cleaning mode of Roborock S50. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 19, 2018
| @@ -208,7 +211,8 @@ def is_on(self) -> bool: | |||
| """True if device is currently cleaning (either automatic, manual or spot).""" | |||
| return self.state_code == 5 or \ | |||
| self.state_code == 7 or \ | |||
| self.state_code == 11 | |||
| self.state_code == 11 or \ | |||
| self.state_code == 17 | |||
There was a problem hiding this comment.
continuation line over-indented for visual indent
| @@ -208,7 +211,8 @@ def is_on(self) -> bool: | |||
| """True if device is currently cleaning (either automatic, manual or spot).""" | |||
| return self.state_code == 5 or \ | |||
| self.state_code == 7 or \ | |||
| self.state_code == 11 | |||
| self.state_code == 11 or \ | |||
There was a problem hiding this comment.
continuation line over-indented for visual indent
|
Changes Unknown when pulling 9d843d9 on hastarin:master into ** on rytilahti:master**. |
|
Thanks! (let's ignore that noise from houndci and merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having trouble getting my new vacuum working with this and home-assistant.
The above changes have allowed me to get up and running at least. If I notice any other issues I'll do my best to fix them and submit pull requests.