New properties of the Xiaomi Air Humidifier added #173

syssi · 2018-01-22T21:50:46Z

No description provided.

coveralls · 2018-01-22T21:53:52Z

Coverage decreased (-0.02%) to 62.141% when pulling 6e083cc on syssi:feature/airhumidifier-new-properties into 9202f1d on rytilahti:master.

coveralls · 2018-01-22T21:53:52Z

Coverage increased (+0.9%) to 63.029% when pulling b3b7e8a on syssi:feature/airhumidifier-new-properties into 9202f1d on rytilahti:master.

houndci-bot · 2018-01-23T05:16:27Z

miio/tests/test_airhumidifier.py

+
+        self.device.set_child_lock(False)
+        assert child_lock() is False
+


blank line at end of file

houndci-bot · 2018-01-23T05:16:28Z

miio/tests/test_airhumidifier.py

@@ -64,6 +69,9 @@ def test_status(self):
        assert self.state().mode == OperationMode(self.device.start_state["mode"])
        assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"])
        assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on')
+        assert self.state().child_lock == (self.device.start_state["child_lock"] == 'on')
+        assert self.state().target_humidity == self.device.start_state["limit_hum"]
+        assert self.state().favorite_level == self.device.start_state["trans_level"]


line too long (84 > 79 characters)

houndci-bot · 2018-01-23T05:16:28Z

miio/tests/test_airhumidifier.py

@@ -64,6 +69,9 @@ def test_status(self):
        assert self.state().mode == OperationMode(self.device.start_state["mode"])
        assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"])
        assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on')
+        assert self.state().child_lock == (self.device.start_state["child_lock"] == 'on')
+        assert self.state().target_humidity == self.device.start_state["limit_hum"]


line too long (83 > 79 characters)

houndci-bot · 2018-01-23T05:16:28Z

miio/tests/test_airhumidifier.py

@@ -64,6 +69,9 @@ def test_status(self):
        assert self.state().mode == OperationMode(self.device.start_state["mode"])
        assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"])
        assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on')
+        assert self.state().child_lock == (self.device.start_state["child_lock"] == 'on')


line too long (89 > 79 characters)

houndci-bot · 2018-01-23T05:16:28Z

miio/tests/test_airhumidifier.py

@@ -1,6 +1,6 @@
 from unittest import TestCase
 from miio import AirHumidifier
-from miio.airhumidifier import OperationMode, LedBrightness
+from miio.airhumidifier import OperationMode, LedBrightness, AirHumidifierException


line too long (83 > 79 characters)

I think houndci should be configured to allow lines up to 100 lines, even when <80 is mostly preferred. This is not a biggie (esp. as it is in the tests), but can be fixed at some point.

houndci-bot · 2018-01-23T05:24:57Z

miio/tests/test_airhumidifier.py

+        assert child_lock() is True
+
+        self.device.set_child_lock(False)
+        assert child_lock() is False


no newline at end of file

It's a good idea to have newlines at the end (for grepping etc.): https://stackoverflow.com/a/729795

I swear there is a newline. I don't know what's going on here.

rytilahti

Looks fine to me, I added a couple of improvement ideas.

rytilahti · 2018-01-23T22:59:47Z

miio/airhumidifier.py

@@ -7,6 +7,10 @@
 _LOGGER = logging.getLogger(__name__)


+class AirHumidifierException(Exception):


This should derive from DeviceException (looks like we have some other exceptions too, which do not do this currently) to allow easy catching of all exception from this library no matter which device is being used.

rytilahti · 2018-01-23T23:00:52Z

miio/airhumidifier.py

+    def set_favorite_level(self, level: int):
+        """Set favorite level."""
+        if level < 30 or level > 85:
+            raise AirHumidifierException("Invalid favorite level: %s" % level)


Is there a link between this level and target humidity (which allows only specific values)?

No. It's more like a "fan speed".

I'm waiting for some details currently: https://community.home-assistant.io/t/xiaomi-humidifier-support/35672/26

Ok, feel free to merge when you are ready 👍

rytilahti · 2018-01-23T23:02:07Z

miio/tests/test_airhumidifier.py

@@ -1,6 +1,6 @@
 from unittest import TestCase
 from miio import AirHumidifier
-from miio.airhumidifier import OperationMode, LedBrightness
+from miio.airhumidifier import OperationMode, LedBrightness, AirHumidifierException


I think houndci should be configured to allow lines up to 100 lines, even when <80 is mostly preferred. This is not a biggie (esp. as it is in the tests), but can be fixed at some point.

rytilahti · 2018-01-23T23:04:16Z

miio/tests/test_airhumidifier.py

+        assert child_lock() is True
+
+        self.device.set_child_lock(False)
+        assert child_lock() is False


It's a good idea to have newlines at the end (for grepping etc.): https://stackoverflow.com/a/729795

syssi · 2018-01-24T08:07:53Z

My last commit doesn't work. Right?

rytilahti · 2018-01-24T16:30:10Z

Hmm, I'm not sure if it's working or not, but nevertheless it's a good idea to have those there. Btw, if it's not too much effort, could you cherrypick 000d06e and 02e1e53 off from this PR and just commit them separately? Then those are visible in commit logs making it easier to remember to add a note about them into the changelog.

Otherwise feel free to commit when you think it's ready 👍

houndci-bot · 2018-01-24T21:12:35Z

miio/tests/test_airhumidifier.py

@@ -64,6 +69,9 @@ def test_status(self):
        assert self.state().mode == OperationMode(self.device.start_state["mode"])
        assert self.state().led_brightness == LedBrightness(self.device.start_state["led_b"])
        assert self.state().buzzer == (self.device.start_state["buzzer"] == 'on')
+        assert self.state().child_lock == (self.device.start_state["child_lock"] == 'on')
+        assert self.state().target_humidity == self.device.start_state["limit_hum"]
+        assert self.state().trans_level == self.device.start_state["trans_level"]


line too long (81 > 79 characters)

rytilahti · 2018-01-24T21:47:09Z

Btw, instead of just reverting you can do a rebase, and simply drop that commit :-) (it will require a force push though..)

New properties added: child_lock, limit_hum, trans_level

6e083cc

syssi added 2 commits January 23, 2018 05:52

trans_level renamed: It's called favorite_level now.

204d0d3

Tests extended.

552327a

houndci-bot reviewed Jan 23, 2018

View reviewed changes

Missing lambda function added.

0d2b4e8

houndci-bot reviewed Jan 23, 2018

View reviewed changes

syssi added 2 commits January 23, 2018 06:38

Tests of the air purifier improved.

aaa7c4e

New line added.

15586f7

syssi changed the title ~~WIP: New properties of the Xiaomi Air Humidifier added~~ New properties of the Xiaomi Air Humidifier added Jan 23, 2018

syssi added 3 commits January 23, 2018 06:44

Provide no buzzer state (true/false) if there is no buzzer available.

51d381b

Typo fixed and volume assertion added to the status call.

cdfe82c

Updates of the air purifier moved to a second pull request.

3eb5c88

rytilahti reviewed Jan 23, 2018

View reviewed changes

syssi added 2 commits January 24, 2018 08:50

All device specific exceptions derives from DeviceException now.

000d06e

Flake8 configuration updated: max-line-length = 100

02e1e53

syssi added 3 commits January 24, 2018 22:06

trans_level is a read-only property and depends on the operation mode.

55b2f0a

DeviceException changes reverted.

29562b5

Test fixed.

ce2c387

houndci-bot reviewed Jan 24, 2018

View reviewed changes

syssi added 2 commits January 25, 2018 07:09

Additional target humidity (30 percent) allowed.

ec258ba

Flake8 configuration reverted.

b3b7e8a

syssi merged commit 79c2904 into rytilahti:master Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New properties of the Xiaomi Air Humidifier added #173

New properties of the Xiaomi Air Humidifier added #173

syssi commented Jan 22, 2018 •

edited

Loading

coveralls commented Jan 22, 2018

coveralls commented Jan 22, 2018 •

edited

Loading

houndci-bot Jan 23, 2018

houndci-bot Jan 23, 2018

houndci-bot Jan 23, 2018

houndci-bot Jan 23, 2018

houndci-bot Jan 23, 2018

rytilahti Jan 23, 2018

houndci-bot Jan 23, 2018

rytilahti Jan 23, 2018

syssi Jan 24, 2018

rytilahti left a comment

rytilahti Jan 23, 2018

rytilahti Jan 23, 2018

syssi Jan 24, 2018

syssi Jan 24, 2018

rytilahti Jan 24, 2018

rytilahti Jan 23, 2018

rytilahti Jan 23, 2018

syssi commented Jan 24, 2018

rytilahti commented Jan 24, 2018

houndci-bot Jan 24, 2018

rytilahti commented Jan 24, 2018 •

edited

Loading


		self.device.set_child_lock(False)
		assert child_lock() is False

		@@ -7,6 +7,10 @@
		_LOGGER = logging.getLogger(__name__)


		class AirHumidifierException(Exception):

New properties of the Xiaomi Air Humidifier added #173

New properties of the Xiaomi Air Humidifier added #173

Conversation

syssi commented Jan 22, 2018 • edited Loading

coveralls commented Jan 22, 2018

coveralls commented Jan 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syssi commented Jan 24, 2018

rytilahti commented Jan 24, 2018

Choose a reason for hiding this comment

rytilahti commented Jan 24, 2018 • edited Loading

syssi commented Jan 22, 2018 •

edited

Loading

coveralls commented Jan 22, 2018 •

edited

Loading

rytilahti commented Jan 24, 2018 •

edited

Loading