Tests for the Chuangmi IR controller #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 27, 2018
miio/tests/test_chuangmi_ir.py
Outdated
| except TypeError: | ||
| return False | ||
|
|
||
| @pytest.fixture(scope="class") |
syssi
force-pushed
the
feature/pytests-chuangmi-ir
branch
from
5d7c5d2 to
5557f99
Compare
rytilahti
reviewed
Jan 27, 2018
miio/chuangmi_ir.py
Outdated
| @@ -13,7 +13,7 @@ class ChuangmiIrException(DeviceException): | |||
| class ChuangmiIr(Device): | |||
| """Main class representing Chuangmi IR Remote Controller.""" | |||
|
|
|||
| def learn(self, key: int): | |||
| def learn(self, key: int = 1): | |||
There was a problem hiding this comment.
You have here whitespaces around = while none for frequency in play, looks fine otherwise so ship it!
rytilahti
previously approved these changes
Jan 27, 2018
rytilahti
dismissed
their stale review
Oops, looks like the tests are failing!
|
@rytilahti Could you check the travis log for an advice? I'm blind and out of ideas. |
rytilahti
reviewed
Jan 28, 2018
miio/tests/test_chuangmi_ir.py
Outdated
| super().__init__(args, kwargs) | ||
|
|
||
| @staticmethod | ||
| def _ir_play_input_validation(self, payload): |
There was a problem hiding this comment.
I think this definition is wrong for a staticmethod, if you remove self it should start working :-)
houndci-bot
reviewed
Jan 28, 2018
miio/tests/test_chuangmi_ir.py
Outdated
| '001600160016004100160041001600410016004100160623' \ | ||
| '015B005700160E6E' | ||
|
|
||
| class DummyChuangmiIr(DummyDevice, ChuangmiIr): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.