Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the path parameter of encode/decode again to be future-proof #223

Closed

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Feb 14, 2018

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.951% when pulling 74e9bed on syssi:feature/construct-encode-decode-path into 26fc798 on rytilahti:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.951% when pulling 74e9bed on syssi:feature/construct-encode-decode-path into 26fc798 on rytilahti:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.951% when pulling 74e9bed on syssi:feature/construct-encode-decode-path into 26fc798 on rytilahti:master.

@rytilahti
Copy link
Owner

I suppose the question to ask here is whether we are more afraid of potential silent errors (which we can handle by checking against incoming kwargs) or changes in the interface used by construct. Maybe keeping the path as it is, and adding **kwargs in case the interface gets extended at some point, to avoid crashing it all immediately?

@yawor
Copy link
Contributor

yawor commented Feb 14, 2018

There's still an open issue #224 when using Construct > 2.9.28.

@arekbulski
Copy link
Contributor

arekbulski commented Feb 15, 2018

Instead of crashing "immediately" due to error explictly related to Adapter code, it will fail "later" due to unknown reasons that dont flag construct lines of code in any way. You might as well wrap you entire code in try/catch and ship it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants