Device support for the xiaomi smart wifi socket added #29

syssi · 2017-07-19T20:04:28Z

No description provided.

houndci-bot · 2017-07-19T20:04:36Z

mirobo/plug.py

+    def status(self):
+        """Retrieve properties."""
+        status =  self.send("get_prop", [PROPERTY_POWER, PROPERTY_TEMPERATURE, PROPERTY_CURRENT])
+        return {PROPERTY_POWER: status[0], PROPERTY_TEMPERATURE: status[1], PROPERTY_CURRENT: status[2]}


line too long (104 > 79 characters)

houndci-bot · 2017-07-19T20:04:36Z

mirobo/plug.py

+
+    def status(self):
+        """Retrieve properties."""
+        status =  self.send("get_prop", [PROPERTY_POWER, PROPERTY_TEMPERATURE, PROPERTY_CURRENT])


multiple spaces after operator
line too long (97 > 79 characters)

houndci-bot · 2017-07-19T20:04:36Z

mirobo/plug.py

+class Plug(Device):
+    """Main class representing the smart wifi socket / plug."""
+
+    def __init__(self, ip: str, token: str, start_id: int = 0, debug: int = 0) -> None:


line too long (87 > 79 characters)

I don't want to fix this. ;-)

Fair enough, I think hound should complain first after 100 characters..

houndci-bot · 2017-07-19T20:04:36Z

mirobo/plug.py

+PROPERTY_TEMPERATURE = 'temperature'
+PROPERTY_CURRENT = 'current'
+
+class Plug(Device):


expected 2 blank lines, found 1

houndci-bot · 2017-07-19T20:04:36Z

mirobo/plug.py

@@ -0,0 +1,29 @@
+from .device import Device, DeviceException


'.device.DeviceException' imported but unused

houndci-bot · 2017-07-19T20:08:38Z

mirobo/plug.py

+        """Retrieve properties."""
+        status =  self.send(
+            "get_prop",
+            [ PROPERTY_POWER, PROPERTY_TEMPERATURE, PROPERTY_CURRENT ]


whitespace after '['
whitespace before ']'

houndci-bot · 2017-07-19T20:08:38Z

mirobo/plug.py

+
+    def status(self):
+        """Retrieve properties."""
+        status =  self.send(


multiple spaces after operator

rytilahti

Looks good! Have you thought how this could look from the side of the console client?

rytilahti · 2017-07-19T21:10:02Z

mirobo/plug.py

+class Plug(Device):
+    """Main class representing the smart wifi socket / plug."""
+
+    def __init__(self, ip: str, token: str, start_id: int = 0, debug: int = 0) -> None:


Fair enough, I think hound should complain first after 100 characters..

rytilahti · 2017-07-19T21:14:20Z

mirobo/plug.py

+
+    def __init__(self, ip: str, token: str, start_id: int = 0, debug: int = 0) -> None:
+        super().__init__(ip, token, start_id, debug)
+        self.manual_seqnum = -1


Is the __init__ here unnecessary though, it just sets the manual_seqnum it never uses :-)

rytilahti · 2017-07-19T21:15:13Z

mirobo/plug.py

+            PROPERTY_POWER: status[0],
+            PROPERTY_TEMPERATURE: status[1],
+            PROPERTY_CURRENT: status[2]
+        }


What type of data is returned by these? Would it make sense to wrap it inside a class like PlugStatus?

rytilahti · 2017-07-19T21:16:32Z

mirobo/plug.py

+
+    def raw_command(self, cmd, params):
+        """Send a raw command to the device."""
+        return self.send(cmd, params)


Is raw_command necessary when send() could be used directly?

houndci-bot · 2017-07-19T21:55:14Z

mirobo/plug.py

+from .device import Device
+from .containers import PlugStatus
+
+class Plug(Device):


expected 2 blank lines, found 1

houndci-bot · 2017-07-19T21:55:14Z

mirobo/containers.py

+        return self.data["current"]
+
+    def __str__(self) -> str:
+        s = "<PlugStatus power=%s, temperature=%s, current=%s>" % (self.state, self.temperature, self.current)


line too long (110 > 79 characters)

houndci-bot · 2017-07-19T21:57:11Z

mirobo/containers.py

+        return self.data["current"]
+
+    def __str__(self) -> str:
+        s = "<PlugStatus power=%s, temperature=%s, " % (self.state, self.temperature)


line too long (85 > 79 characters)

syssi · 2017-07-19T22:05:17Z

Looks good! Have you thought how this could look from the side of the console client?

I have no idea honestly. Just provide a second CLI called "plug"?

rytilahti · 2017-07-20T17:52:29Z

mirobo/containers.py

+        s = "<PlugStatus power=%s, " % (self.state)
+        s += "temperature=%s, " % (self.temperature)
+        s += "current=%s>" % (self.current)
+        return s


I think:

s = "<PlugStatus power=%s, temperature=%s, current=%s>" % (self.state, self.temperature, self.current)

Properly intended would look nicer, but this is fine too.

rytilahti · 2017-07-20T17:54:03Z

That, or using the same client but providing "methods" depending on the discovered device type, considering that there are quite a bit of devices which could be easily supported. I think this can be merged already now.

houndci-bot · 2017-07-21T07:14:28Z

mirobo/containers.py

+    def __str__(self) -> str:
+        s = "<PlugStatus power=%s, temperature=%s, current=%s>" % (self.state,
+                                                                   self.temperature,
+                                                                   self.current)


line too long (80 > 79 characters)

houndci-bot · 2017-07-21T07:14:28Z

mirobo/containers.py

+
+    def __str__(self) -> str:
+        s = "<PlugStatus power=%s, temperature=%s, current=%s>" % (self.state,
+                                                                   self.temperature,


line too long (84 > 79 characters)

houndci-bot · 2017-07-21T11:03:10Z

mirobo/plug_cli.py

+import sys
+import json
+import ipaddress
+from typing import Any


'typing.Any' imported but unused

houndci-bot · 2017-07-21T11:03:10Z

mirobo/plug_cli.py

+import pretty_cron
+import ast
+import sys
+import json


'json' imported but unused

houndci-bot · 2017-07-21T11:03:10Z

mirobo/plug_cli.py

+# -*- coding: UTF-8 -*-
+import logging
+import click
+import pretty_cron


'pretty_cron' imported but unused

rytilahti · 2017-07-21T12:58:04Z

Thanks, maybe in the future it makes sense to just extend one tool to cover all the devices, but the cli solution shall work for now :-)

syssi · 2017-08-03T21:02:33Z

$ .local/bin/mirobo --ip 192.168.130.57 --token b051cdxxxxxxxxxxxxxxxxxxxxxxxdb -d info
INFO:mirobo.vacuum_cli:Debug mode active
DEBUG:mirobo.vacuum_cli:Read stored sequence ids: {'seq': 7, 'manual_seq': 0}
DEBUG:mirobo.vacuum_cli:Connecting to 192.168.130.57 with token b051cdxxxxxxxxxxxxxxxxxxxxxxxdb
DEBUG:mirobo.protocol:Unable to decrypt, returning raw bytes.
DEBUG:mirobo.device:Discovered 843 14557 with ts: 1970-01-01 01:14:27
DEBUG:mirobo.device:192.168.130.57:54321 >>: {'id': 8, 'params': [], 'method': 'miIO.info'}
DEBUG:mirobo.device:192.168.130.57:54321 (ts: 1970-01-01 01:14:27, id: 8) << {'id': 8, 'result': {'life': 4467, 'hw_ver': 'MW300', 'netif': {'localIp': '192.168.130.57', 'mask': '255.255.255.0', 'gw': '192.168.130.1'}, 'model': 'chuangmi.plug.m1', 'cfg_time': 0, 'otu_stat': [303, 300, 12, 0, 12, 567], 'wifi_fw_ver': 'SD878x-14.76.36.p84-702.1.0-WM', 'ot': 'otu', 'token': 'b051cdxxxxxxxxxxxxxxxxxxxxxxxdb', 'fw_ver': '1.2.4_16', 'mac': '28:6C:FF:FF:FF:FF', 'ap': {'bssid': 'C0:25:06:A8:9A:5E', 'rssi': -69, 'ssid': 'Greendale'}, 'ott_stat': [0, 0, 0, 0], 'mmfree': 30296}}
chuangmi.plug.m1 v1.2.4_16 (28:6C:FF:FF:FF:FF) @ 192.168.130.57 - token: b051cdxxxxxxxxxxxxxxxxxxxxxxxdb
DEBUG:mirobo.vacuum_cli:Full response: {'ap': {'bssid': 'C0:25:06:A8:9A:5E', 'rssi': -69, 'ssid': 'Greendale'},
 'cfg_time': 0,
 'fw_ver': '1.2.4_16',
 'hw_ver': 'MW300',
 'life': 4467,
 'mac': '28:6C:FF:FF:FF:FF',
 'mmfree': 30296,
 'model': 'chuangmi.plug.m1',
 'netif': {'gw': '192.168.130.1',
           'localIp': '192.168.130.57',
           'mask': '255.255.255.0'},
 'ot': 'otu',
 'ott_stat': [0, 0, 0, 0],
 'otu_stat': [303, 300, 12, 0, 12, 567],
 'token': 'b051cdxxxxxxxxxxxxxxxxxxxxxxxdb',
 'wifi_fw_ver': 'SD878x-14.76.36.p84-702.1.0-WM'}
DEBUG:mirobo.vacuum_cli:Writing {'seq': 8, 'manual_seq': 0} to /tmp/python-mirobo.seq

Device support for the xiaomi smart wifi socket added.

311537d

houndci-bot reviewed Jul 19, 2017

View reviewed changes

Code reformatted.

cea4e70

houndci-bot reviewed Jul 19, 2017

View reviewed changes

Code reformatted.

e243faa

rytilahti reviewed Jul 19, 2017

View reviewed changes

Some refactoring.

bea60f6

houndci-bot reviewed Jul 19, 2017

View reviewed changes

Code reformatted.

8c34d51

houndci-bot reviewed Jul 19, 2017

View reviewed changes

Code reformatted.

e331b9d

rytilahti reviewed Jul 20, 2017

View reviewed changes

Code reformatted.

c8777c6

houndci-bot reviewed Jul 21, 2017

View reviewed changes

syssi added 3 commits July 21, 2017 09:18

Code reformatted.

7b0829b

Bugfix.

df9f45d

Command line interface called "miplug" added.

18f3c7e

houndci-bot reviewed Jul 21, 2017

View reviewed changes

Unused imports removed.

401dee4

rytilahti merged commit e1ab84c into rytilahti:master Jul 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Device support for the xiaomi smart wifi socket added #29

Device support for the xiaomi smart wifi socket added #29

syssi commented Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

syssi Jul 19, 2017

rytilahti Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

rytilahti left a comment

rytilahti Jul 19, 2017

rytilahti Jul 19, 2017

rytilahti Jul 19, 2017

rytilahti Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

houndci-bot Jul 19, 2017

syssi commented Jul 19, 2017

rytilahti Jul 20, 2017

rytilahti commented Jul 20, 2017

houndci-bot Jul 21, 2017

houndci-bot Jul 21, 2017

houndci-bot Jul 21, 2017

houndci-bot Jul 21, 2017

houndci-bot Jul 21, 2017

rytilahti commented Jul 21, 2017

syssi commented Aug 3, 2017

Device support for the xiaomi smart wifi socket added #29

Device support for the xiaomi smart wifi socket added #29

Conversation

syssi commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syssi commented Jul 19, 2017

Choose a reason for hiding this comment

rytilahti commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti commented Jul 21, 2017

syssi commented Aug 3, 2017