Support of multiple zones for app_zoned_cleaning #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 23, 2018
miio/vacuum.py
Outdated
| ) | ||
| def zoned_clean(self, *zones): | ||
| """Cleans zoned areas. | ||
| :enter one or multiple zones: [x1,y1,x2,y2, iterations],[x1,y1,x2,y2, iterations]: |
miio/tests/test_vacuum.py
Outdated
| def test_zoned_clean(self): | ||
| self.device.start() | ||
| assert self.status().is_on is True | ||
| self.device.zoned_clean([25000, 25000, 25500, 25500, 3],[23000, 23000, 22500, 22500, 1]) |
houndci-bot
reviewed
Apr 23, 2018
miio/vacuum_cli.py
Outdated
| """Going to target.""" | ||
| click.echo("Going to target : %s" % vac.goto()) | ||
|
|
||
| @cli.command() |
miio/vacuum_cli.py
Outdated
| @@ -196,6 +196,17 @@ def home(vac: miio.Vacuum): | |||
| """Return home.""" | |||
| click.echo("Requesting return to home: %s" % vac.home()) | |||
|
|
|||
| @cli.command() | |||
|
Do you still need help or does it work already? |
|
I couldn't test the changes, so I have no idea if this works. Also, I wasn't really sure how to setup the click.arguments, so somebody should have a look at these anyway. |
8 tasks
app_goto_target and app_zoned_clean
houndci-bot
reviewed
Aug 21, 2018
miio/vacuum.py
Outdated
| return self.send("app_goto_target", | ||
| [x_coord, y_coord]) | ||
|
|
||
| @command( |
There was a problem hiding this comment.
redefinition of unused 'zoned_clean' from line 86
miio/vacuum.py
Outdated
| @@ -102,6 +101,30 @@ def zoned_clean(self, x1_coord: int, y1_coord: int, | |||
| return self.send("app_zoned_clean", | |||
| [x1_coord, y1_coord, x2_coord, y2_coord, iterations]) | |||
|
|
|||
| @command( | |||
There was a problem hiding this comment.
redefinition of unused 'goto' from line 76
syssi
changed the title
houndci-bot
reviewed
Aug 21, 2018
miio/vacuum.py
Outdated
| [x1_coord, y1_coord, x2_coord, y2_coord, iterations]) | ||
| def zoned_clean(self, zones: List): | ||
| """Cleans zoned areas. | ||
| :param List zones: List of zones to clean: [[x1,y1,x2,y2, iterations],[x1,y1,x2,y2, iterations]]""" |
There was a problem hiding this comment.
line too long (107 > 100 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vacuum only accepts zones within a list, so even a single list has to be passed like this:
[[x1,y1,x2,y2, iterations]]
The current code only sends "[x1,y1,x2,y2, iterations]" to the vacuum, so it does not work. I tried to change the code so that it accepts multiple zones, but I am not sure if it works like this. In addition, I have no no idea how to define the click.argument for a list. So I definitely going to need help on this one.