Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a name clash of click_common and the argument "command" #328

Merged
merged 1 commit into from
Jun 2, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jun 2, 2018

of device methods (Closes: #325)

@syssi syssi requested a review from rytilahti June 2, 2018 07:25
@syssi
Copy link
Collaborator Author

syssi commented Jun 2, 2018

@yawor Is a rename of the variable a proper approach? A leading underscore looks weird.

@coveralls
Copy link

coveralls commented Jun 2, 2018

Coverage Status

Coverage remained the same at 72.353% when pulling ef34c29 on syssi:feature/miiocli-command-name-clash into a639b12 on rytilahti:master.

@yawor
Copy link
Contributor

yawor commented Jun 2, 2018

Rename either that or the "command" argument in chuangmi_ir to "ir_command" or something like that.
The arg name in the command_callback is used strictly internally, so this is probably a better way, as it doesn't really affect anything.

@syssi
Copy link
Collaborator Author

syssi commented Jun 2, 2018

There are some more methods with a parameter called "command". That's the cause, why I choose this approach.

@syssi syssi merged commit 2f0b75a into rytilahti:master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants