Device support for the chuangmi plug v1 added #33
Conversation
|
|
||
| class PlugV1Status: | ||
| """Container for status reports from the plug.""" | ||
| def __init__(self, data: Dict[str, Any]) -> None: |
There was a problem hiding this comment.
undefined name 'Dict'
undefined name 'Any'
There was a problem hiding this comment.
An example would also be nice here :-) Are those values already booleans or should they be converted below?
There was a problem hiding this comment.
I asked for the response at the same post: https://community.home-assistant.io/t/xiaomi-mi-wifi-plug-air-purifier/16189/99
There was a problem hiding this comment.
Oops, sorry for that, too many PRs got me confused. However, I think we can already merge this after fixing the conflict and update the information when we receive it. Btw, here's someone with the purifier, so at least we can get it tested easily, I hope: https://community.home-assistant.io/t/xiaomi-mi-air-purifier-support/14228/12
|
Do you happen to have the devtype (assuming it's usable at all..) / other identifying information we could use for discovering these new devices? The PR looks fine otherwise. |
syssi
changed the title
|
I requested the devtype and hope for feedback: https://community.home-assistant.io/t/xiaomi-mi-wifi-plug-air-purifier/16189/99 |
|
Btw, for the future, it's usually better to rebase than merge on PRs to keep the commit log cleaner :-) |
|
Got it. Thanks! I'm learning a lot. |
|
We are also going to need |
|
The output is of the correct device if it contains |
|
Thanks again :) I think we are going to need to update the README to have information about other supported devices & their models. |
No description provided.