Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vacuum's got_error: compare against error code, not against the state #379

Merged
merged 1 commit into from
Sep 14, 2018
Merged

vacuum's got_error: compare against error code, not against the state #379

merged 1 commit into from
Sep 14, 2018

Conversation

rytilahti
Copy link
Owner

The vacuum changes the state to error state only for a short period of time before returning to a "Disconnected" state if nothing else happens.

This will change the behaviour of got_error to check the error code against 0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.716% when pulling 9def869 on vacuum_fix_got_error into 11ea2a0 on master.

@rytilahti rytilahti mentioned this pull request Sep 11, 2018
Merged
8 tasks
@rytilahti
Copy link
Owner Author

Merging as there's been no objections.

@rytilahti rytilahti merged commit b464727 into master Sep 14, 2018
@rytilahti rytilahti deleted the vacuum_fix_got_error branch September 14, 2018 18:02
@rytilahti rytilahti mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rytilahti @coveralls