Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation for token from Android backup #382

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

sgtio
Copy link
Contributor

@sgtio sgtio commented Sep 30, 2018

Add information about the initial setup of the device, and the steps
needed prior to creating the backup.

@coveralls
Copy link

coveralls commented Sep 30, 2018

Coverage Status

Coverage remained the same at 72.987% when pulling e71826d on sgtio:master into c2b213c on rytilahti:master.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, it's great to have a more proper documentation for newcomers to follow (and other to link to), so this is greatly appreciated! Can you please check that one change I commented, it does seem to be accidental.

@@ -174,7 +198,7 @@ to the tool with ``--password <password>``.
MAC: 28:6C:07:XX:XX:XX
room1
Model: yeelink.light.color1
IP address: 192.168.XXX.XXX
\IP address: 192.168.XXX.XXX
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this is accidental. I'll fix it!
Thanks for the feedback!

Add information about the initial setup of the device, and the steps
needed prior to creating the backup.
@sgtio
Copy link
Contributor Author

sgtio commented Oct 1, 2018

I have squashed the commit with the typo fix. Please let me know if you prefer having 2 separate commits. Thanks!

@rytilahti
Copy link
Owner

It is fine, we'll simply squash & merge it. Thanks a lot for helping with the documentation!

@rytilahti rytilahti merged commit 78b7553 into rytilahti:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants