Handle "resp invalid json" error (Closes: #205) #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
reviewed
Jan 7, 2019
rytilahti
reviewed
Jan 7, 2019
| raise DeviceError(m.data.value["error"]) | ||
| error = m.data.value["error"] | ||
| if "code" in error and error["code"] == -30001: | ||
| raise RecoverableError(error) |
There was a problem hiding this comment.
We want to have this codepath tested too (at some point, maybe there are also other recoverable cases?) :-)
There was a problem hiding this comment.
Do you've an idea how to test this part?
There was a problem hiding this comment.
I think the way to go would be mocking the Message.parse() to return with that error code, and then checking that it gets called retry_count times. #437 may simplify the tests (or we might split the code even a bit more to make it easier to test). I think this can wait for now, feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#19787, too.