Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename speed property to avoid a name clash at HA #466

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Rename speed property to avoid a name clash at HA #466

merged 1 commit into from
Jan 22, 2019

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 22, 2019

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.461% when pulling 3801c51 on syssi:feature/airhumidifer-ca1-rename-speed into df92e62 on rytilahti:master.

@syssi
Copy link
Collaborator Author

syssi commented Jan 22, 2019

This line must be updated as soon as python-miio 0.4.5 is released:

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/fan/xiaomi_miio.py#L235

@syssi syssi merged commit 26c2155 into rytilahti:master Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syssi @coveralls