add mi dehumidifier v1 (nwt.derh.wdh318efw1) #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! Do you like to provide some tests, too? |
houndci-bot
reviewed
Aug 1, 2019
miio/tests/test_airdehumidifier.py
Outdated
| assert self.state().target_humidity == self.device.start_state["auto"] | ||
| assert self.state().fan_speed == FanSpeed(self.device.start_state["fan_speed"]) | ||
| assert self.state().tank_full == (self.device.start_state["tank_full"] == 'on') | ||
| assert self.state().compressor_status == (self.device.start_state["compressor_status"] == 'on') |
There was a problem hiding this comment.
line too long (103 > 100 characters)
miio/tests/test_airdehumidifier.py
Outdated
|
|
||
| device_info = DeviceInfo(self.device.dummy_device_info) | ||
|
|
||
| assert repr(self.state()) == repr(AirDehumidifierStatus(self.device.start_state, device_info)) |
There was a problem hiding this comment.
line too long (102 > 100 characters)
houndci-bot
reviewed
Aug 1, 2019
miio/tests/test_airdehumidifier.py
Outdated
| assert self.state().fan_speed == FanSpeed(self.device.start_state["fan_speed"]) | ||
| assert self.state().tank_full == (self.device.start_state["tank_full"] == 'on') | ||
| assert self.state().compressor_status == \ | ||
| (self.device.start_state["compressor_status"] == 'on') |
There was a problem hiding this comment.
continuation line over-indented for visual indent
miio/tests/test_airdehumidifier.py
Outdated
| device_info = DeviceInfo(self.device.dummy_device_info) | ||
|
|
||
| assert repr(self.state()) ==\ | ||
| repr(AirDehumidifierStatus(self.device.start_state, device_info)) |
There was a problem hiding this comment.
continuation line over-indented for visual indent
|
@syssi right? |
|
@rytilahti |
|
From the surface it looks good to me, but I'll let @syssi to merge it when he sees it's fine :-) |
|
@syssi Thanks |
|
I will prepare a release soonish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Add support for WIDETECH WDH318EFW1 dehumidifier (nwt.derh.wdh318efw1) #534