Add initial support for Xiao AI Smart Alarm Clock (zimi.clock.myk01) #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 10, 2019
houndci-bot
reviewed
Oct 10, 2019
|
If the conflict and unused import is fixed could we just merge this PR? It's more likely somebody improves the support if it's part of the libary instead of an pending PR. |
houndci-bot
reviewed
Oct 19, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./miio/alarmclock.py:233:-355: W605 invalid escape sequence '\/'
./miio/alarmclock.py:233:-355: W605 invalid escape sequence '\/' ./miio/alarmclock.py:233:-24: W605 invalid escape sequence '\/' ./miio/alarmclock.py:248:-148: W605 invalid escape sequence '\/' ./miio/alarmclock.py:248:-146: W605 invalid escape sequence '\/'
houndci-bot
reviewed
Oct 19, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
./miio/alarmclock.py:233:-355: W605 invalid escape sequence '\/'
./miio/alarmclock.py:233:-355: W605 invalid escape sequence '\/' ./miio/alarmclock.py:233:-24: W605 invalid escape sequence '\/' ./miio/alarmclock.py:248:-148: W605 invalid escape sequence '\/' ./miio/alarmclock.py:248:-146: W605 invalid escape sequence '\/'
|
Agreed on that, that's why I decided to PR it even when it's not yet ready :-) I fixed the linting issues and added some more commentary for anyone interested in working on it, I think this can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I don't have access to the device I'm not interested in this, but it would work as a base for someone to finish the support.
Fixes #505