Add Device.get_properties(), cleanup devices using get_prop #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will move common handling for property request splitting, and verifying the results, into the Device class. Also, add tests for this functionality.
|
Let's merge this as it's a showstopper for improving the miot support, this should be anyway a non-breaking change. |
rytilahti
added a commit
that referenced
this pull request
Jul 2, 2020
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
…i#745) This regression was caused by clean-up done in rytilahti#657 Fixes rytilahti#730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will move common handling for property request splitting,
and verifying the results, into the Device class.
Also, add tests for this functionality.