Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chuangmi.plug.v3: Fixed power state status for updated firmware #665

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

ad
Copy link
Contributor

@ad ad commented Apr 11, 2020

@coveralls
Copy link

coveralls commented Apr 11, 2020

Coverage Status

Coverage remained the same at 73.181% when pulling 05a18f4 on ad:master into 093b6b1 on rytilahti:master.

@rytilahti rytilahti changed the title Fixed power state status for updated firmware chuangmi.plug.v3: Fixed power state status for updated firmware Apr 12, 2020
@rytilahti
Copy link
Owner

I don't think this this really fixes the issue, considering that the first check will always return True for non-empty string values too (i.e., off would be matched, too), right?

miio/chuangmi_plug.py Outdated Show resolved Hide resolved
Co-Authored-By: Teemu R. <tpr@iki.fi>
@rytilahti rytilahti merged commit d661953 into rytilahti:master Apr 13, 2020
@matteos1
Copy link

is it possible to correct this error in home assistant?

@rytilahti
Copy link
Owner

It will correct itself when we make a new release, and homeassistant updates to that.

@matteos1
Copy link

matteos1 commented Apr 25, 2020

in release 0.109?

@rytilahti
Copy link
Owner

No, 0.109 beta is already out so it will likely land in 0.110.

@matteos1
Copy link

matteos1 commented Apr 30, 2020

is it possible in future release of 0.109.x ? thank you

No, 0.109 beta is already out so it will likely land in 0.110.

@rytilahti
Copy link
Owner

I wanted to get some of the currently open PRs merged first, but maybe I'll cut a new release over the weekend and see if we can get it into some .x homeassistant release!

@matteos1
Copy link

thank you

@matteos1
Copy link

matteos1 commented May 20, 2020

I wanted to get some of the currently open PRs merged first, but maybe I'll cut a new release over the weekend and see if we can get it into some .x homeassistant release!

same problem on 0.110 the switch is always on :(

@matteos1
Copy link

matteos1 commented Jun 3, 2020

I wanted to get some of the currently open PRs merged first, but maybe I'll cut a new release over the weekend and see if we can get it into some .x homeassistant release!

@rytilahti have you update chuangmi_plug.py?

@acelauwc
Copy link

acelauwc commented Sep 3, 2020

As of today, its still not in the home assistant release 0.114.4

For those who cannot wait, you can manually edit chuangmi_plug.py (line 49) in your home assistant miiio directory to reflect the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants