First draft of the water purifier support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 8, 2017
mirobo/waterpurifier.py
Outdated
| @@ -0,0 +1,57 @@ | |||
| import logging | |||
| from typing import Any, Dict, Optional | |||
There was a problem hiding this comment.
'typing.Optional' imported but unused
mirobo/discovery.py
Outdated
| @@ -25,7 +25,7 @@ | |||
| "zhimi-airpurifier-v6": AirPurifier, | |||
| "chuangmi-ir-v2": ChuangmiIr, | |||
| # "zhimi-humidifier-v1": Humidifier, | |||
| # "yunmi-waterpuri-v2": WaterPurifier, | |||
| "yunmi-waterpuri-v2": WaterPurifier, | |||
|
We can add it, but maybe it makes sense to add a call for help to the README.md regarding to missing functionality? |
|
You are right. I will extend the README.md! |
syssi
force-pushed
the
feature/waterpurifier
branch
from
d8d4c51 to
2e2d21b
Compare
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exact feature set is unkown at the moment. A list of supported properties / some network traffic would be nice.