Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send multiple handshake requests #686

Merged
merged 1 commit into from
May 16, 2020
Merged

send multiple handshake requests #686

merged 1 commit into from
May 16, 2020

Conversation

rytilahti
Copy link
Owner

send several handshake requests as an experiment to improve the transmission rate. reuses retry_count to decide on the number of requests to send.

potential fix for discovery problems, e.g., home-assistant/core#21899

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 73.895% when pulling 248d033 on improve_handshaking into 85e119c on master.

@rytilahti
Copy link
Owner Author

As it doesn't do much harm to send multiple handshakes, I'll merge it even when it doesn't fix the connectivity issues for everyone.

@rytilahti rytilahti merged commit fe031c5 into master May 16, 2020
@rytilahti rytilahti deleted the improve_handshaking branch January 5, 2021 23:09
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants